4 ms·
Oh, the first job as intern lasted a year, then my next (where people came to me for help) was for 1.5 years. I committed some code that wasn't the most effici
by knicholes 14y ago
Oh, the first job as intern lasted a year, then my next (where people came to me for help) was for 1.5 years. I committed some code that wasn't the most efficient-- Like there was an error where a user didn't have a profile, so instead of going into the database and making every user have a profile, I added the code that checked if they had one, and if not, it created one. I did things like that. I left a console.log statement on one of the pages which broke some features for IE users for a couple days.
One issue, for sure, is I was intimidated by the guy who handed the project off to me. Nothing I did seemed to be good enough. I did a Model.object.get() to test if it exists instead of a Model.objects.filter().exists(). So my code wasn't extremely efficient. I don't think that that kind of the thing TERRIBLE, but it is what it is. We had a big argument about git workflow. I was making individual feature branches with ticket numbers that matched up with our bug tracker. When tested locally, I'd push to a staging server, test it there, then merge the feature branch into master, and push live. He said I was making it too complicated and that stage needed to be exactly like production. I'm used to stage being a playground. He told me that that was what local development was for. I thought it was easier to test the stripe webhooks on the staging server instead of doing some DNS crap so I could get stripe webhooks locally.
Ah, I also committed to the master branch code that had a template tag error. I corrected it after about 5 minutes (and nobody had triggered the error. I triggered it when testing some other push I had). I wrote it off as being human, but he wrote it off as being bad.
It sucks to think that a couple small mistakes early on means I get fired, though.