4 ms·
The log viewer and query tools looks excellent. Here are some (hopefully) constructive comments: - As others have mentioned, change the NS prefix. Only Apple
by pkaler 14y ago
The log viewer and query tools looks excellent.
Here are some (hopefully) constructive comments:
- As others have mentioned, change the NS prefix. Only Apple should be using that.
- The API is not canonical looking Objective-C/Cocoa. It looks like the programmer has a Windows/C++ background
- I only took a quick look but I didn't see logging macros that conditionally compile out logging for release builds
- Internally the logger uses pthreads. This is going to make it difficult on a client that uses Grand Central Dispatch to reason about code when they are debugging something. Consider using queues and operations rather than firing up worker threads. Take a look at CocoaLumberjack for their approach
- Create a Cocoapod to spur adoption
- MaxGabriel 14y agoThere's a .podspec file in the repository and a matching Cocoapod: https://github.com/fpillet/NSLogger https://github.com/fpillet/NSLogger
- i386 14y agoIs there a good guide to writing canonical looking Objective-C /Cocoa APIs? I read the .NET Framework Design Guidelines back when I was doing .NET and it was an excellent how to guide on writing APIs that behaved and felt like they were part of the BCL. Something like that for Objective-C and Cocoa would be a boon.