2 ms·
It's a cultural thing, but you can do incremental PRs towards a large goal. Giant PRs that are expected to be reviewed never really seemed worth it imho.
by gedy 24d ago
It's a cultural thing, but you can do incremental PRs towards a large goal. Giant PRs that are expected to be reviewed never really seemed worth it imho.
- pc86 23d agoI don't think a PR needs to be tens of thousands of lines for a review to take more than 20 minutes. I've worked on projects where you can't reasonably get a branch set up and running somewhere to test it within 20 minutes if you need to set up dependencies, peripherals, external systems, etc.