4 ms·
Well are we talking about commits pre- or post-merge? I don’t care how many commits you put into the PR / MR as long as they squash down to a single commit upon
by datsci_est_2015 1mo ago
Well are we talking about commits pre- or post-merge? I don’t care how many commits you put into the PR / MR as long as they squash down to a single commit upon merge.
- steveklabnik 1mo agoWhen you work this way, each commit is expected to be able to land independently.
- datsci_est_2015 1mo agoDoesn’t sound like it leaves much room for error. How do you address PR / MR comments? Force push?
- steveklabnik 1mo agoThe reason people like to work this way is that it lets you very effectively respond to review. You address them by amending the commit to incorporate the feedback. This enables good interdiff review, so you can re-review just the new stuff in the new version of the commit and not the entire thing all over again.