3 ms·
That seems to be what's happening. Like 2-4 bots talking to each other, then Jarred Sumner just does the final merge with little comment. https://github.com/ov
by collinmanderson 1mo ago
That seems to be what's happening. Like 2-4 bots talking to each other, then Jarred Sumner just does the final merge with little comment.
https://github.com/oven-sh/bun/pull/39743 https://github.com/oven-sh/bun/pull/39743
https://github.com/oven-sh/bun/pull/39735 https://github.com/oven-sh/bun/pull/39735
- rafram 1mo agogithub-actions: "If you need a paragraph-long comment to justify why the workaround is OK, the code is wrong — fix the code" robobun: "The ordering is load-bearing: reclaiming before this block made is_dead_request true and hung a parked textStream read (caught by body.test.ts in CI). The comment pins that constraint." Ah, well, if something is load-bearing, then I guess that settles it. Need a comment to pin that constraint, in case a read is parked. These are words that normal humans commonly use in these ways. (Always striking how much Claude obsesses over the minutiae of method contracts and side effects, exhaustively documenting them in comments. It’s much happier figuring out how to reorder some method calls with nonobvious side effects so the code works than it is refactoring them not to do unexpected things!)