7 ms·
It's a code review, right? Give feedback that about the docs and block merging till the issue is resolved.
by BeetleB 2mo ago
It's a code review, right?
Give feedback that about the docs and block merging till the issue is resolved.
- Gigachad 2mo agoYou can't keep up with the slop. And before you finish a first pass read on the wall of diff, another AI sloperator on the team has hit approve and the PR is merged.
- LPisGood 2mo agoExactly this. Even if I spend a bunch of time requesting a review — and our team does respect each other enough to at least nominally respond to comments before merging — the update itself will be another thousand line diff from the original that requires again the same level of review or I just accept that it looks fine.
- account42 2mo agoAt that point maybe go looking for a company with a better work environment.
- deleted 2mo ago[deleted]
- LPisGood 2mo agoThis sounds easy in principle, but a half dozen of these sort sorts of massive PR’s per week is basically untenable. I’m not gonna read the hundreds of lines of added documentation to decide if they’re correct or not. The price of generating new words is just so much higher than the price of evaluating it that I can’t be bothered.
- BeetleB 2mo ago> but a half dozen of these sort sorts of massive PR’s per week is basically untenable. Actually, rejecting them is precisely what will make them easy. "Sorry, the comments are so bad I'm stopping here. Please fix them and then I'll resume the code review." You're giving everybody (including yourself) more work by: 1. Reviewing the code (even if you skip the documentation). 2. Letting too many abstruse comments in which everyone in the team will have to read. 3. Allowing the behavior to continue. Become the bottleneck so the team can talk about it. If they decide this shouldn't be a blocker, just declare you won't review the comments going forward.
- LPisGood 2mo agoI think you’re overestimating how easy it is to just declare I won’t be doing my job.
- BeetleB 2mo agoI am actually asking you to do your job. Pre-LLMs, if I got comments that were difficult to read in a code review, that PR isn't getting merged until they fix it. So: Review the docs. If it's that bad, just say "I don't understand these comments" and send it back.
- LPisGood 2mo agoWhat I’m trying to say is that they can generate many more hundreds of lines of code and comments than I can reasonably review. Maybe the comments do make sense they’re just five lines longer than they ought to be. Multiply that by 20 times and then add in 150 lines of documentation that is not technically incorrect. Not to mention that the response to each review will come with its own set of new comments and new documentation. The ability of people to write things has exploded tenfold. You can’t out review the slop. Every PR can be rewritten and re-architected on a whim.
- BeetleB 2mo agoSure - but the volume is a separate problem from the quality of comments. Even if the comments were the best possible your complaint would still stand.
- latentsea 2mo agoTbh if the AI just followed the prompt to not add the comments, that'd be sufficient. It feels maddening and burnout inducing to tell it not to only to have it ignore that and you deal with the same problem every time without things meaningfully improving.
- 27183 2mo ago
- tcmart14 2mo agoJust hit "deny." I've been training my co-workers that the AI-isms their "AI Assisted coding" do that some shit just isn't acceptable. I leave a comment and hit deny. It also helps that I control the policies on the repo and they can't merge in with a denial from anyone. So it's either a fix it, or explain why your work isn't getting done. My manager is also 100% with this. I've denied for poor branch names and commits from AI. I've denied for too verbose of comments from AI. I've denied for parts of the code base being touched that are not relevant to the case they are working on (login isn't broken, your case is to add a check box in the settings pane, remove the changes made to login). Pre-AI I wasn't fine with PRs with multiple features and touching irrelevant areas of the code base. Why would I be fine with it because my co-workers got new toys? You want AI to refactor a part of the codebase? Fine. Separate branch, new PR, and in the description, present an argument for it. Don't shoe horn it into something else. Also, I'm not obligated to hit approved on shit. I may also be a bit privileged because I can be a pain in the ass to whole team. I may be slower, but I've got the numbers, my code is creating way less bugs then my "fast more efficient" co-workers.
- miraculixx 2mo agoClose the PRs as unacceptable.