3 ms·
I think ripgrep does avoid allocations in that innermost loop. That's why this report says all the crashes are associated with opendir() and its memory allocat
by entrope 2mo ago
I think ripgrep does avoid allocations in that innermost loop. That's why this report says all the crashes are associated with opendir() and its memory allocation: the opendir() call is outside of ripgrep's innermost loop but still runs often enough to trigger the race condition.
- mort96 2mo agoAnd that's why musl's allocator's performance isn't a huge concern for ripgrep
- Orphis 2mo agoThat's to be properly measured. Assuming that the allocator will not cause issues there is to be proven. The application I recently improved by changing the allocator had a similar profile (a C++ include scanner) and thread parallel I/O functions had terrible performance originally with mallocng. Adding threads almost had negative value because of the contention.