5 ms·

Guido apparently wrote a web-based code review tool for Google: http://www.niallkennedy.com/blog/2006/11/google-mondrian.html http://www.niallkennedy.com/blog/

Guido apparently wrote a web-based code review tool for Google: http://www.niallkennedy.com/blog/2006/11/google-mondrian.html http://www.niallkennedy.com/blog/2006/11/google-mondrian.htm...

briancurtin 14y ago
http://code.google.com/p/rietveld/ http://code.google.com/p/rietveld/
lquist 14y ago
I heard that this tool was not well received at Google; anybody else hear this?
- MatthewPhillips 14y ago
  Git is not well received at Google either.
  - kibwen 14y ago
    Care to elaborate? I'm curious to hear why this might be.
  - packetslave 14y ago
    This is not true. I use git practically every day, working within the main source tree. Google's a big company with thousands of engineers and multiple ways of doing things. Some use git, some don't. You use what works best for you.
  - vl 14y ago
    Not true, a lot of people, including me, use git at Google. It's not a default options, but you can use it if you want to.
- btilly 14y ago
  When I was there, everyone I knew used it and sang its praises. But it is a large company with a lot of teams. I am sure there were people somewhere who thought it was awful.
  - rachelbythebay 14y ago
    When it worked, it was great. When it was down or slow (Friday at 4:15 PM, anyone?), it was miserable.
    - SimHacker 14y ago
      Hey wait, doesn't everybody at Google stay till 10:00 PM on Friday??!
      - Evbn 14y ago
        Still need to beat the pre TGIF rush. Reviewing code after happy hour is a bad idea.
      - jholman 14y ago
        They kinda kick everybody out on Friday evenings, actually. (Not actually kick out, but make it easier to just go home, especially as compared with Mon-Thurs.) And, in fact, that's even more true now than it was two weeks ago, because of a change in food-service policy.
  - jaimebuelta 14y ago
    I use Rietveld (not in Google) and I'm not particularly impress. It makes the job, but I don't think is a GREAT tool. After all, there are not many ways you can do a code review... I'd love something that will be more integrated with source control (git in particular), maybe I'm asking too much...
    - motti 14y ago
      Try Gerrit. It's tightly coupled to git, it's quite easy to host, similar to Rietveld/Mondrian in style, and has good documentation.
- vl 14y ago
  Not true, it is a part of the required standard check-in process for the long time and just recently was replaced with the V2.
- cpsales 14y ago
  LGTM

Guido apparently wrote a web-based code review tool for Google: http://www.niallkennedy.com/blog/2006/11/google-mondrian.html http://www.niallkennedy.com/blog/2006/11/google-mondrian.htm...

briancurtin 14y ago

http://code.google.com/p/rietveld/ http://code.google.com/p/rietveld/

lquist 14y ago

I heard that this tool was not well received at Google; anybody else hear this?

MatthewPhillips 14y ago
Git is not well received at Google either.
- kibwen 14y ago
  Care to elaborate? I'm curious to hear why this might be.
- packetslave 14y ago
  This is not true. I use git practically every day, working within the main source tree. Google's a big company with thousands of engineers and multiple ways of doing things. Some use git, some don't. You use what works best for you.
- vl 14y ago
  Not true, a lot of people, including me, use git at Google. It's not a default options, but you can use it if you want to.
btilly 14y ago
When I was there, everyone I knew used it and sang its praises. But it is a large company with a lot of teams. I am sure there were people somewhere who thought it was awful.
- rachelbythebay 14y ago
  When it worked, it was great. When it was down or slow (Friday at 4:15 PM, anyone?), it was miserable.
  - SimHacker 14y ago
    Hey wait, doesn't everybody at Google stay till 10:00 PM on Friday??!
    - Evbn 14y ago
      Still need to beat the pre TGIF rush. Reviewing code after happy hour is a bad idea.
    - jholman 14y ago
      They kinda kick everybody out on Friday evenings, actually. (Not actually kick out, but make it easier to just go home, especially as compared with Mon-Thurs.) And, in fact, that's even more true now than it was two weeks ago, because of a change in food-service policy.
- jaimebuelta 14y ago
  I use Rietveld (not in Google) and I'm not particularly impress. It makes the job, but I don't think is a GREAT tool. After all, there are not many ways you can do a code review... I'd love something that will be more integrated with source control (git in particular), maybe I'm asking too much...
  - motti 14y ago
    Try Gerrit. It's tightly coupled to git, it's quite easy to host, similar to Rietveld/Mondrian in style, and has good documentation.
vl 14y ago
Not true, it is a part of the required standard check-in process for the long time and just recently was replaced with the V2.
cpsales 14y ago
LGTM