3 ms·

Hmm my suggestions: - Please make the "show changes" scale to large code changes. I've been bitten by hanging browsers a few times while trying to review pull

Hmm my suggestions: - Please make the "show changes" scale to large code changes. I've been bitten by hanging browsers a few times while trying to review pull requests in which many files were changed significantly or added. One (simple) way would be to show just the changed files, in collapsed form, which can be expanded. - Add a way to increase the size of the diff context Sometimes the given context is not large enough, especially if a file has many similar functions. For example in vimdiff you can "expand the hidden lines" in this case.

jakub_g 14y ago
@wladimir Have a look at the Firefox userscript I wrote very recently: http://userscripts.org/scripts/show/153049 http://userscripts.org/scripts/show/153049 -- feedback welcome! Of course it doesn't eliminate the big initial fetch from the served, just collapses it once loaded to have more friendly UI.
- wladimir 14y ago
  Thanks for the link, looks useful. That would be functionality that should be in Github itself. Good to see that I'm not the only one with that pet peeve.
sdesol 14y ago
Disclaimer: I'm the founder of a company that has been working on solving the problems that you have described for the last year. Having developed internal tools for large enterprise environments with over 50,000 developers with massive code bases (think linux kernel times 10), it has always baffled me why GitHub and others seem to think stuffing all the changes on a single page is a good idea. Sure it's great when the changes are small but having to deal with large changes is not an unusual edge case. Especially in the enterprise environment where process and politics tends to create backlogs in merging which forces us to have to deal with large changes at once. Below are some sample screen shots with how we deal with changes. Viewing pull request detail http://6b507fb6377c7b2ce0ed-f6f6a52addfcf546a4b633fce1dd247e.r94.cf1.rackcdn.com/pull-request-1.png http://6b507fb6377c7b2ce0ed-f6f6a52addfcf546a4b633fce1dd247e... If the changes are really massive, we offer the ability to navigate the changes as a code churn tree. We call this the divide and conquer way of managing large diffs. http://6b507fb6377c7b2ce0ed-f6f6a52addfcf546a4b633fce1dd247e.r94.cf1.rackcdn.com/code-churn-tree.png http://6b507fb6377c7b2ce0ed-f6f6a52addfcf546a4b633fce1dd247e... We also make it possible for you to break apart the commits that are included in the pull request with our commits browser. Note the revisions tree on the left that shows you all the revisions. http://6b507fb6377c7b2ce0ed-f6f6a52addfcf546a4b633fce1dd247e.r94.cf1.rackcdn.com/commits.png http://6b507fb6377c7b2ce0ed-f6f6a52addfcf546a4b633fce1dd247e... As for the diff issue. We have the ability for you to create your own custom diff views. See the following screen shot. http://6b507fb6377c7b2ce0ed-f6f6a52addfcf546a4b633fce1dd247e.r94.cf1.rackcdn.com/add-diff-view.png http://6b507fb6377c7b2ce0ed-f6f6a52addfcf546a4b633fce1dd247e... With the custom diff view, we make it very easy for you to manipulate the diff output.

jakub_g 14y ago

@wladimir Have a look at the Firefox userscript I wrote very recently: http://userscripts.org/scripts/show/153049 http://userscripts.org/scripts/show/153049 -- feedback welcome! Of course it doesn't eliminate the big initial fetch from the served, just collapses it once loaded to have more friendly UI.

wladimir 14y ago
Thanks for the link, looks useful. That would be functionality that should be in Github itself. Good to see that I'm not the only one with that pet peeve.

sdesol 14y ago

Disclaimer: I'm the founder of a company that has been working on solving the problems that you have described for the last year. Having developed internal tools for large enterprise environments with over 50,000 developers with massive code bases (think linux kernel times 10), it has always baffled me why GitHub and others seem to think stuffing all the changes on a single page is a good idea. Sure it's great when the changes are small but having to deal with large changes is not an unusual edge case. Especially in the enterprise environment where process and politics tends to create backlogs in merging which forces us to have to deal with large changes at once. Below are some sample screen shots with how we deal with changes. Viewing pull request detail http://6b507fb6377c7b2ce0ed-f6f6a52addfcf546a4b633fce1dd247e.r94.cf1.rackcdn.com/pull-request-1.png http://6b507fb6377c7b2ce0ed-f6f6a52addfcf546a4b633fce1dd247e... If the changes are really massive, we offer the ability to navigate the changes as a code churn tree. We call this the divide and conquer way of managing large diffs. http://6b507fb6377c7b2ce0ed-f6f6a52addfcf546a4b633fce1dd247e.r94.cf1.rackcdn.com/code-churn-tree.png http://6b507fb6377c7b2ce0ed-f6f6a52addfcf546a4b633fce1dd247e... We also make it possible for you to break apart the commits that are included in the pull request with our commits browser. Note the revisions tree on the left that shows you all the revisions. http://6b507fb6377c7b2ce0ed-f6f6a52addfcf546a4b633fce1dd247e.r94.cf1.rackcdn.com/commits.png http://6b507fb6377c7b2ce0ed-f6f6a52addfcf546a4b633fce1dd247e... As for the diff issue. We have the ability for you to create your own custom diff views. See the following screen shot. http://6b507fb6377c7b2ce0ed-f6f6a52addfcf546a4b633fce1dd247e.r94.cf1.rackcdn.com/add-diff-view.png http://6b507fb6377c7b2ce0ed-f6f6a52addfcf546a4b633fce1dd247e... With the custom diff view, we make it very easy for you to manipulate the diff output.