6 ms·
Is this a good commit message?
- ams6110 14y agoNo, it's not a good message. It's masturbation. Fun for the person who wrote it, but useless to anyone else.
- asdfaoeu 14y agoWhat is this the anti-fun brigade?
- maw 14y agoSounds like a reasonable question, actually: is it a good commit message? I'm really not sure, but am inclined towards yes.
- thisone 14y agoIf they'd managed to work in the actual reason for the change, it'd be just that much better. Other than that, that's one bored dev. Or, that's the kind of stuff I write when I'm bored and punchy at the end of a long night.
- burke 14y agoIt's not, as it doesn't do anything to describe the problem or the solution. However, the change is so trivial that it's immediately apparent, so who cares :)
- skeltoac 14y agoI enjoyed it despite its failure to describe the changeset. More good than harm. I was glad he did it. The author subtly called out each WordPress core team member in the text with personal attributes and inside jokes. Even without that context, a person could enjoy it.
- saraid216 14y agoIt's a terrible commit message, but for the case it was fixing, seriously, why care? If I found it in something I was working on, I'd laugh and move on with my life.
- georgeorwell 14y agoI don't know. The writing is okay, there weren't any spelling mistakes that I noticed, but the use of three words written in only capital letters was somewhat disconcerting. I'd say if the author wants to get it accepted for publication somewhere reasonably mainstream he's going to need someone else working at arm's length who is willing to take the time to go through it and highlight areas for revision and expansion before sending it back to him. The author and this person might need to repeat the process a few times.
- mdpye 14y agoSubsides -> subsists. Not strictly spelling, but definitely a mistake... Otherwise a pretty awesome commit message. Better than my personal most used (before work moved to git and let me rewrite local history): "oops, forgot to add the new file" and "oops, fix up the bloody test"...
- nacin 14y agoYup, I realized the typo this morning. Hanging my head in shame. In fairness, this message was written at 4am after working for 18 hours straight (and 63 of the previous 84 hours, according to rescuetime).
- deleted 14y ago[deleted]
- mdpye 14y agoIn terms of git features, I think I value correcting embarrassing typos in my commit messages higher than fixing typos in my code! They're a lot more frequent due to the fast and loose typing, and lack of a compiler on my back.
- chc 14y agoIf you're working in PHP, you should be used to fast and loose typing (also the lack of a compiler unless you work at Facebook).
- zalew 14y agoit's not hosted on github, so by hn standards I don't know if it can be qualified as an opensource contribution at all.
- dkasper 14y agoIt was a joke: https://twitter.com/nacin/status/276769136829423616 https://twitter.com/nacin/status/276769136829423616
- zalew 14y agothanks for clarifying, I was just about to investigate this issue.
- malkia 14y agoIt is a joke, but one of the best commit message I've seen lately is from PostgreSQL - for example from Tom Lane - where each bug, or new feature is explained well. I wish I can write such. My commit messages are terrible to my home projects, at least at work I'm following some established rules and it's easier there...
- peterjmag 14y agoAt least it's not something entirely useless like "updated", "w00t", "oops", "test", or " ". (And yes, I've come across all of those in the wild.)
- nsxwolf 14y ago"Latest updates"
- zalew 14y agosome fixes
- zbowling 14y agoWIP
- FuzzyDunlop 14y ago"Commit that shit", after watching the wire.
- tobych 14y agovarious changes (not tested)
- georgeorwell 14y agohi
- ardiyu07 14y ago(space)
- Yver 14y agoI have a bash alias for `git commit -a -mWIP` in my fuckit branch.
- yakiv 14y agoThe English word "apron", as I understand it, used to be "napron". "A napron" eventually shifted to "an apron". See http://www.thefreedictionary.com/Napron http://www.thefreedictionary.com/Napron.
- xnxn 14y agoThat's funny, the reverse process created the word "nuncle" from "mine uncle". http://en.wiktionary.org/wiki/nuncle http://en.wiktionary.org/wiki/nuncle
- thezilch 14y agoNo, the initial part of the message should be a short log that does not exceed 78 characters. /monocle
- michaelfeathers 14y agoYes.
- cjensen 14y agoNo. People don't read commit logs for fun. They read them to try to find the source of a bug or who changed a line last and what they thought they were doing. This breaks that functionality in two ways: 1. Recognizing the joke takes attention, which therefore means I have less attention available to track the thing I'm really hunting. The thing I'm hunting may take a lot of "state info" in my brain so I need that concentration. A commit log of "fix typo" can be quickly ignored without interrupting my brain state. 2. The commit log is not self-explainatory. You have to look at the diff to understand the joke. The whole point of a commit log is to summarize the change so I don't need to look at the diffs unless the commit is related to the functionality I'm investigating. "Fix typo" followed by the joke would have been acceptable.
- deleted 14y ago[deleted]
- skyebook 14y agoCouldn't agree more. I'll also be the first to admit though that some commit messages I've sent off after particularly infuriating bugs have had language that my mother would slap me for (and not very helpful, to boot). We're only human
- sophacles 14y agoSometime's I feel like I'm the only person who understands code. Seriously, I don't look at comments, api docs, or commit logs unless I am unsure what the diff or code is telling me. I mean, joking with something this trivial is not really a big deal. There is no hidden motivation to change it, no hard to follow changes, no clever bits of code that are subtly altered. An output string is now without a typo. Big whoop. The only complaint that makes sense is "it's not that funny".
- qeorge 14y agoI hate this attitude. Really do. Its a cancer. You're not "the only person who understands code", you're the person who refuses to write good documentation based on a misplaced sense of superiority. Get over yourself.
- fleitz 14y agoSure, it's great! It's somewhat funny and really long. It will take up lots of time for those dumb enough to try to find bugs by reading commit messages rather than use a the proper tool for the job which would of course be: git/svn bisect.
- mixedbit 14y agoThis indeed is an issue of extreme importance. I'm afraid only Linus Torvalds is qualified to pass a judgement on the quality of this commit message. Fortunately, he isn't quick to judge: https://github.com/torvalds/linux/pull/17#issuecomment-5659970 https://github.com/torvalds/linux/pull/17#issuecomment-56599... ;)
- tokipin 14y agowhats wrong with 1