3 ms·
No, reviewing PRs in general is a delightful process. The tedious part is in the initial triage when the PR comes from a previously unknown submitter, and you c
by pferde 3mo ago
No, reviewing PRs in general is a delightful process. The tedious part is in the initial triage when the PR comes from a previously unknown submitter, and you cannot be sure what is the intention of the submitter, what is their technical level, whether they are talking out of their ass or not.
It's basically the same issue as spam in emails. It was bad before, and automation made it a zillion times worse.
- bluefirebrand 3mo ago> No, reviewing PRs in general is a delightful process I don't know if this is a very universal feeling. I personally find reviewing code is tedious compared to writing it Not just the process of reading the code and understanding it, but the back and forth can be miserable if the submitter isn't meeting you part way I dunno. Maybe I'm the odd one out for thinking reviewing PRs is more of a chore than a joy
- pferde 3mo agoThat, not being sure if the submitter is willing to meet you part way, is exactly the miserable part I am talking about. Basically, you go in risking it's just a waste of your time. After some trust is established, or when the PR is from someone you already have some trust relationship, the dynamics are very different. Yes, it can still be a slog to review someone else's code, but you usually have the feeling of "hey, this is probably something good".