5 ms·

A few questions/thoughts: * Why is the "build" target still there? * Why don't you use `$^` in rules like the one for "bootstrap/js/.js" instead of listing o

by endgame 14y ago

A few questions/thoughts: * Why is the "build" target still there? * Why don't you use `$^` in rules like the one for "bootstrap/js/.js" instead of listing out the files by hand? A lot of your rules have a wildcard in the target part, which means something like `bootstrap/css/.css: less/.less` actually expands to "bootstrap/css/bootstrap.css bootstrap/css/bootstrap-responsive.css bootstrap/css/bootstrap.min.css bootstrap/css/bootstrap-responsive.min.css: less/bootstrap.less less/responsive.less". THAT expands to: bootstrap/css/bootstrap.css: less/bootstrap.less less/responsive.less bootstrap/css/bootstrap-responsive.css: less/bootstrap.less less/responsive.less bootstrap/css/bootstrap.min.css: less/bootstrap.less less/responsive.less bootstrap/css/bootstrap-responsive.min.css: less/bootstrap.less less/responsive.less (All of which have identical commands.) This can potentially break under a make -j (parallel make). Hang on. I'll cook up a pull request.

jazzychad 14y ago
Thanks! I'm not a make expert by any means, so any improvements are welcome.. I just did the minimum amount to make it faster. I knew the wildcards would expand, but the subsequent expansions would have their dependencies fulfilled by the first one of them that triggered the commands, so it should short circuit (however you are right, it will be wonky under -j). I left the "build" target in case I submit a pull request upstream and didn't want to completely upset the apple-cart; it's still useful to compile the docs. Also, I just pushed another update to my repo, just fyi in case you are editing for a pull request.
- endgame 14y ago
  While trying to merge your update, I accidentally my entire git stash. I'll have another go later and send you a pull request.
  - jazzychad 14y ago
    ooooh bummer, sorry about that :( looking forward to it.
  - dbaupp 14y ago
    Depending on what happened, git often keeps old references around for a while, so, for example, you can recover dropped stashes: http://stackoverflow.com/questions/89332/recover-dropped-stash-in-git http://stackoverflow.com/questions/89332/recover-dropped-sta...
    - endgame 14y ago
      Success. Thank you.

by endgame 14y ago

jazzychad 14y ago

Thanks! I'm not a make expert by any means, so any improvements are welcome.. I just did the minimum amount to make it faster. I knew the wildcards would expand, but the subsequent expansions would have their dependencies fulfilled by the first one of them that triggered the commands, so it should short circuit (however you are right, it will be wonky under -j). I left the "build" target in case I submit a pull request upstream and didn't want to completely upset the apple-cart; it's still useful to compile the docs. Also, I just pushed another update to my repo, just fyi in case you are editing for a pull request.

endgame 14y ago
While trying to merge your update, I accidentally my entire git stash. I'll have another go later and send you a pull request.
- jazzychad 14y ago
  ooooh bummer, sorry about that :( looking forward to it.
- dbaupp 14y ago
  Depending on what happened, git often keeps old references around for a while, so, for example, you can recover dropped stashes: http://stackoverflow.com/questions/89332/recover-dropped-stash-in-git http://stackoverflow.com/questions/89332/recover-dropped-sta...
  - endgame 14y ago
    Success. Thank you.