4 ms·
One thing that annoys me is that mapping Jira tickets 1:1 with PRs yields very large PRs that have to be reviewed as a whole. This seems to happen a lot in fron
by rbanffy 5mo ago
One thing that annoys me is that mapping Jira tickets 1:1 with PRs yields very large PRs that have to be reviewed as a whole. This seems to happen a lot in front-end work, where some PRs touch 40 files or so.
I prefer to keep my PRs under 10 files.
While I was writing this I thought it might be handy to have a counter somewhere (in the zsh prompt or VSCode) showing files and line count for the difference between your branch and the upstream to serve as a reminder of when it’s time to make a PR.
- VladNiculescu 5mo agoThat is a good point. I do have an automation that kicks in when I make a PR that reviews my code at the end and shows me if I have any files above 300 lines.
- rbanffy 5mo ago> I have any files above 300 lines. I draw the line at 1000.