4 ms·
Squash merging PRs makes your commit log is far less useful. The PR reviewer isn't the only person who will ever review your code, you know.
by dolni 4mo ago
Squash merging PRs makes your commit log is far less useful.
The PR reviewer isn't the only person who will ever review your code, you know.
- lelandfe 4mo agoI felt similarly. But I'm also usually the only person Tim Pope'ing my commits. If you police atomic feature branch PRs instead of atomic feature branch commits, though, things actually work out OK. (By the way, the even more compelling next step to your argument is: pull requests aren't artifacts! I've worked on projects that have emigrated from GitHub, and was left with just the commit log)