3 ms·
The CEO of Shopify is filing PRs against their public repos: https://github.com/Shopify/liquid/pull/2056 https://github.com/Shopify/liquid/pull/2056 (To be fai
by simonw 5mo ago
The CEO of Shopify is filing PRs against their public repos: https://github.com/Shopify/liquid/pull/2056 https://github.com/Shopify/liquid/pull/2056
(To be fair, he did build liquid and much of Shopify himself at the start of the company so he's not exactly inexperienced, but still.)
- khuey 5mo agoI skimmed that PR briefly and it appears a) not to be slop and b) to be very reviewable as its structured as a series of small commits that each make one small change. This is far from the sort of management PR I'd fear.
- suttontom 5mo agoAm I going crazy? Is a PR with 94 commits that adds 1,600 LoC actually considered "very reviewable"? Please someone tell me if I'm crazy?