3 ms·

You do realize that you're complaining about the Claude Code TUI, right? That's not what this product is; merely a tool it uses.

pprotas 5mo ago
You claim "very high quality" but can't even get the basic UI working properly. You wrap tmux and a container in 2k lines of code and claim quality, I think the comment above was aimed at this claim.
- kstenerud 5mo ago
  The UI is working properly. Interfering with Anthropic's UI, or any of the other agent harness' UIs it supports, would be madness incarnate. I also strongly suspect that you'd only taken a cursory glance at the top of the readme prior to passing judgment.
  - deleted 5mo ago
    [deleted]
  - embedding-shape 5mo ago
    I did not much more than a cursory glance too, but found "./sandbox/create.go", a ~1300 lines long file with so much duplication even within just itself that I stopped counting. Now it was a long time ago I did Go professionally, but I'm also in the camp of "That doesn't really count as high-quality", although I know for a fact you can get quality code out of LLMs, but I don't think that's a good showcase of that.
    - kstenerud 5mo ago
      > I did not much more than a cursory glance too, but found "./sandbox/create.go", a ~1300 lines long file with so much duplication even within just itself that I stopped counting. Really? What duplication did you actually find? I count a few small ones in buildMounts and ReadPrompt, maybe 20 lines or so, but hardly anything worthy of such an epithet. Admittedly, the parsing & escaping code and some utility functions could be moved outside to shrink the file, but otherwise I'm having trouble finding issues with the code.
      - embedding-shape 5mo ago
        The duplication I'm seeing isn't just "same text repeated" but structural duplication. Doing a quick 5 minute look again just to give you some pointers; runtime.MountSpec construction in buildMounts, Workdir vs aux-dir mount-mode handling, repeated one-off mount append blocks, overlay detection and so on, the list goes on. Just those should account for 200+ lines. Look for slight variations of the same thing but with different paths, variables, or modes and I think you'd be able to spot the rest as well.
        kstenerud 5mo ago
        You consider adding in-place constructed items to an array to be code duplication?
        freedomben 5mo ago
        I've noticed that the bar for "quality" when people judge AI is often significantly higher than what they'd hold a human to. I'm not saying GP et al are doing this (I haven't looked myself), but it is a widespread pattern I've noticed both professionally and personally. I don't know why it is.
        kenjackson 5mo ago
        I have seen it too. The answer is easy - they don’t like AI. I've seen similar things with some people that don’t like women in tech or certain minorities - they suddenly critique at an extremely high level. I also haven’t looked at this particular case, but it wouldn’t surprise me to be the same thing here.
        TurkTurkleton 5mo ago
        Dude, are you for real? We've had the supposed inevitability of AI rammed down our throats since the minute LaMDA convinced Blake Lemoine it was sentient, we've watched CEOs hype up AI as if it were production-ready while it was still barely beta quality, LLM-driven chatbots have been stapled to the side of every product no matter how little sense it makes since OpenAI published an API, and we've been told to prepare for the inevitable "agentic future" even as Claude 3.5 had to have its hand held more than a wet-behind-the-ears freshman summer intern. We're told that this technology is going to eat the entire world economy and render human labor obsolete, starting with our jobs, but if it's genuinely supposed to do that, I think it's more than reasonable to expect it to write superhumanly perfect code, not just code that's incrementally better than the last model release but still bad; extraordinary claims require extraordinary evidence, after all. To liken AI skepticism to the obstacles faced by women and minorities in tech is a category error that trivializes actual human struggles against human prejudices.
  - everforward 5mo ago
    I looked through and there's a bunch of stuff that's in poor coding practice. E.g. https://github.com/kstenerud/yoloai/blob/main/internal/fileutil/fileutil.go#L54 https://github.com/kstenerud/yoloai/blob/main/internal/fileu... <- that recursively creates directories, but will only change permissions on the innermost dir (user may be unable to cd into intermediary directories) https://github.com/kstenerud/yoloai/blob/main/internal/mcpsrv/tools.go#L195 https://github.com/kstenerud/yoloai/blob/main/internal/mcpsr... <- all the json.Marshal calls in this file just suppress errors, so if anything un-marshallable ends up in there the app will return empty strings with no errors logged https://github.com/kstenerud/yoloai/blob/main/runtime/registry.go#L23 https://github.com/kstenerud/yoloai/blob/main/runtime/regist... <- `Register` embeds a copy of the code from `IsAvailable` because of the locking; that could be replaced with a private `isAvailable` that has no locking that both use (after doing their own locking) https://github.com/kstenerud/yoloai/blob/main/runtime/exec.go https://github.com/kstenerud/yoloai/blob/main/runtime/exec.g... <- these functions are identical except for the strings.Trim, one should just call the other and then trim the output Just out of curiosity, I enabled some other linters and it looks bad. Excluding test files, there are 110 functions with a cyclomatic complexity over 10 and 7 that are _over 50_. The worst is at 86, which is mind-boggling. Could probably find more, but you get the drift. I'm sure it runs, but stylistically this is more along the lines of what I would expect an intern to do. This is also sort of nit-picky, but like half the stuff in https://github.com/kstenerud/yoloai/blob/main/docs/dev/backend-idiosyncrasies.md#osstat-on-the-containerd-socket-does-not-detect-permission-denied https://github.com/kstenerud/yoloai/blob/main/docs/dev/backe... isn't idiosyncratic, it's just the way those things work and a lot of them aren't even tricky. The one linked is particularly blatant; that's not limited to os.Stat that's literally just how permissions work. Denying permission on inodes is a property of the folder, not the file.
Philip-J-Fry 5mo ago
So why has your tool completely broken the Claude Code UI then? Can't you see in the gif? It's completely broken. My Claude doesn't look like that. Neither does anyone else's.
- kstenerud 5mo ago
  Claude Code will automatically "dumb" the TUI down a bit when it can't properly detect certain terminal capabilities, to avoid potential font rendering issues. Likely there are some terminal caps that aren't being properly preserved inside of the sandbox. It's never bothered me since the agent itself works fine.
  - Philip-J-Fry 5mo ago
    Yeah, so whatever you're doing to wrap Claude is broken. Because it's breaking the UI. "It's never bothered me". Cool. But your tool is bugged.
    - kstenerud 5mo ago
      Feel free to open a bug report if it bothers you. Or a PR. Or feel free to avoid the tool entirely if this UI issue shakes your faith in its overall quality down to its very foundations. This is hardly a hill to die on.
      - sjagauanbdvva 5mo ago
        You’re missing the point. You claimed high quality and provided a repo. Did you not expect someone to actually look and critique it? Whether the visual bugs are a deal breaker or not isn’t the point. The point is that’s not high quality code, it may work. But it’s not code I would ship at my job and therefore it’s not high enough quality for anyone serious
        kstenerud 5mo ago
        Hey that's fine. You're free to make whatever judgment you wish. But I still stand by the quality of my code, including here. You and I don't need to agree. What decades of managing codebases (public and private, huge and small) has taught me is that there will always be an endless list of bugs and feature ideas and nice-to-haves and technical debt pressures in any given project. You'll never get to them all, so you prioritize (as I have done here). Functional bugs usually trump visual ones unless they're actually interfering with work. Will I fix this bug? Probably, now that I'm aware of it. But there are more important matters to attend to first. Edit: Turns out the bug comes from a mismatch with the terminal I'm using. With other terminals it looks fine. Term caps are surprisingly complicated, especially when you have multiple layers!

pprotas 5mo ago

You claim "very high quality" but can't even get the basic UI working properly. You wrap tmux and a container in 2k lines of code and claim quality, I think the comment above was aimed at this claim.

kstenerud 5mo ago
The UI is working properly. Interfering with Anthropic's UI, or any of the other agent harness' UIs it supports, would be madness incarnate. I also strongly suspect that you'd only taken a cursory glance at the top of the readme prior to passing judgment.
- deleted 5mo ago
  [deleted]
- embedding-shape 5mo ago
  I did not much more than a cursory glance too, but found "./sandbox/create.go", a ~1300 lines long file with so much duplication even within just itself that I stopped counting. Now it was a long time ago I did Go professionally, but I'm also in the camp of "That doesn't really count as high-quality", although I know for a fact you can get quality code out of LLMs, but I don't think that's a good showcase of that.
  - kstenerud 5mo ago
    > I did not much more than a cursory glance too, but found "./sandbox/create.go", a ~1300 lines long file with so much duplication even within just itself that I stopped counting. Really? What duplication did you actually find? I count a few small ones in buildMounts and ReadPrompt, maybe 20 lines or so, but hardly anything worthy of such an epithet. Admittedly, the parsing & escaping code and some utility functions could be moved outside to shrink the file, but otherwise I'm having trouble finding issues with the code.
    - embedding-shape 5mo ago
      The duplication I'm seeing isn't just "same text repeated" but structural duplication. Doing a quick 5 minute look again just to give you some pointers; runtime.MountSpec construction in buildMounts, Workdir vs aux-dir mount-mode handling, repeated one-off mount append blocks, overlay detection and so on, the list goes on. Just those should account for 200+ lines. Look for slight variations of the same thing but with different paths, variables, or modes and I think you'd be able to spot the rest as well.
      - kstenerud 5mo ago
        You consider adding in-place constructed items to an array to be code duplication?
        freedomben 5mo ago
        I've noticed that the bar for "quality" when people judge AI is often significantly higher than what they'd hold a human to. I'm not saying GP et al are doing this (I haven't looked myself), but it is a widespread pattern I've noticed both professionally and personally. I don't know why it is.
        kenjackson 5mo ago
        I have seen it too. The answer is easy - they don’t like AI. I've seen similar things with some people that don’t like women in tech or certain minorities - they suddenly critique at an extremely high level. I also haven’t looked at this particular case, but it wouldn’t surprise me to be the same thing here.
        TurkTurkleton 5mo ago
        Dude, are you for real? We've had the supposed inevitability of AI rammed down our throats since the minute LaMDA convinced Blake Lemoine it was sentient, we've watched CEOs hype up AI as if it were production-ready while it was still barely beta quality, LLM-driven chatbots have been stapled to the side of every product no matter how little sense it makes since OpenAI published an API, and we've been told to prepare for the inevitable "agentic future" even as Claude 3.5 had to have its hand held more than a wet-behind-the-ears freshman summer intern. We're told that this technology is going to eat the entire world economy and render human labor obsolete, starting with our jobs, but if it's genuinely supposed to do that, I think it's more than reasonable to expect it to write superhumanly perfect code, not just code that's incrementally better than the last model release but still bad; extraordinary claims require extraordinary evidence, after all. To liken AI skepticism to the obstacles faced by women and minorities in tech is a category error that trivializes actual human struggles against human prejudices.
- everforward 5mo ago
  I looked through and there's a bunch of stuff that's in poor coding practice. E.g. https://github.com/kstenerud/yoloai/blob/main/internal/fileutil/fileutil.go#L54 https://github.com/kstenerud/yoloai/blob/main/internal/fileu... <- that recursively creates directories, but will only change permissions on the innermost dir (user may be unable to cd into intermediary directories) https://github.com/kstenerud/yoloai/blob/main/internal/mcpsrv/tools.go#L195 https://github.com/kstenerud/yoloai/blob/main/internal/mcpsr... <- all the json.Marshal calls in this file just suppress errors, so if anything un-marshallable ends up in there the app will return empty strings with no errors logged https://github.com/kstenerud/yoloai/blob/main/runtime/registry.go#L23 https://github.com/kstenerud/yoloai/blob/main/runtime/regist... <- `Register` embeds a copy of the code from `IsAvailable` because of the locking; that could be replaced with a private `isAvailable` that has no locking that both use (after doing their own locking) https://github.com/kstenerud/yoloai/blob/main/runtime/exec.go https://github.com/kstenerud/yoloai/blob/main/runtime/exec.g... <- these functions are identical except for the strings.Trim, one should just call the other and then trim the output Just out of curiosity, I enabled some other linters and it looks bad. Excluding test files, there are 110 functions with a cyclomatic complexity over 10 and 7 that are _over 50_. The worst is at 86, which is mind-boggling. Could probably find more, but you get the drift. I'm sure it runs, but stylistically this is more along the lines of what I would expect an intern to do. This is also sort of nit-picky, but like half the stuff in https://github.com/kstenerud/yoloai/blob/main/docs/dev/backend-idiosyncrasies.md#osstat-on-the-containerd-socket-does-not-detect-permission-denied https://github.com/kstenerud/yoloai/blob/main/docs/dev/backe... isn't idiosyncratic, it's just the way those things work and a lot of them aren't even tricky. The one linked is particularly blatant; that's not limited to os.Stat that's literally just how permissions work. Denying permission on inodes is a property of the folder, not the file.

Philip-J-Fry 5mo ago

So why has your tool completely broken the Claude Code UI then? Can't you see in the gif? It's completely broken. My Claude doesn't look like that. Neither does anyone else's.

kstenerud 5mo ago
Claude Code will automatically "dumb" the TUI down a bit when it can't properly detect certain terminal capabilities, to avoid potential font rendering issues. Likely there are some terminal caps that aren't being properly preserved inside of the sandbox. It's never bothered me since the agent itself works fine.
- Philip-J-Fry 5mo ago
  Yeah, so whatever you're doing to wrap Claude is broken. Because it's breaking the UI. "It's never bothered me". Cool. But your tool is bugged.
  - kstenerud 5mo ago
    Feel free to open a bug report if it bothers you. Or a PR. Or feel free to avoid the tool entirely if this UI issue shakes your faith in its overall quality down to its very foundations. This is hardly a hill to die on.
    - sjagauanbdvva 5mo ago
      You’re missing the point. You claimed high quality and provided a repo. Did you not expect someone to actually look and critique it? Whether the visual bugs are a deal breaker or not isn’t the point. The point is that’s not high quality code, it may work. But it’s not code I would ship at my job and therefore it’s not high enough quality for anyone serious
      - kstenerud 5mo ago
        Hey that's fine. You're free to make whatever judgment you wish. But I still stand by the quality of my code, including here. You and I don't need to agree. What decades of managing codebases (public and private, huge and small) has taught me is that there will always be an endless list of bugs and feature ideas and nice-to-haves and technical debt pressures in any given project. You'll never get to them all, so you prioritize (as I have done here). Functional bugs usually trump visual ones unless they're actually interfering with work. Will I fix this bug? Probably, now that I'm aware of it. But there are more important matters to attend to first. Edit: Turns out the bug comes from a mismatch with the terminal I'm using. With other terminals it looks fine. Term caps are surprisingly complicated, especially when you have multiple layers!