4 ms·
As someone who is currently refactoring a giant mess, this is a terrible article. The problems are myriad: - we have people mixing camelCase and underscores
by alanctgardner2 14y ago
As someone who is currently refactoring a giant mess, this is a terrible article.
The problems are myriad:
- we have people mixing camelCase and underscores
- we have tab indents and four space indents, and eight space indents
- program state is all stored in one giant struct, making the code impossible to reuse
- methods are giant, rambling monsters with at least 6 levels of indentation
Coding style is important, is what I'm saying.
- joshAg 14y agoHeck, I'd even settle for a much less than good coding style, as long as it's consistent throughout a project.
- barrkel 14y agoWhat you are complaining about is incompetence, not a standards document.
- alanctgardner2 14y agoI wouldn't describe it as incompetent, it's just not forward thinking. We have a loosely enforced style guide that should prevent the formatting and casing issues, but what we need is actually a more dictatorial approach. As I'm rewriting, I'm producing a style guide which is more prescriptive about things that matter, like writing reusable code. This includes trying to identify hotspots where extensibility is very important, versus areas where the code just needs to be readable and work. These deserve more love and attention from an architecture perspective.