4 ms·

There was also the code search, uh, I forgot the name "quick change", I believe? Very handy for seeing a problem, quickly solving it (sending out a CL) marking

by spwa4 6mo ago

There was also the code search, uh, I forgot the name "quick change", I believe? Very handy for seeing a problem, quickly solving it (sending out a CL) marking it autosubmit and just moving on.

randomCloud 6mo ago
I assume quick change became critique?
- hcnews 6mo ago
  There was a code reviewer starting with M before Critique iirc (Mondrian I wanna say?). The M code reviewer was completely written in Python iirc.
  - spwa4 6mo ago
    No I mean that in code search you could click "edit" and just change something, which would then post a CL immediately, which you could set to auto-approve, for quick changes. I believe it was part of cider (the first non-vscode version)
    - bruckie 6mo ago
      The first version was part of Code Search proper, and wasn't super useful for much more than just typo fixes, since it was essentially just a textarea edit box. That was eventually deprecated and replaced with a button that did the same thing, but opened in Cider instead.
  - rcleveng 6mo ago
    Yup, you guessed it. I was the eng manager for that for a bit, added some APIs to use to do code reviews inside of Eclipse or IntelliJ. That idea never took on, but when when I showed it to the code search team in Munich, they loved it. Critique was a fast follow.
  - jbstjohn 6mo ago
    Yep, and written by Guido von Rossum, no less. However, experience with it led to my sense that Python just doesn't scale (especially back then, without type annotations) past a certain size of program. The Code Search team had been re-inventing its UI and changing a lot (changing its focus from external to internal), and had the inspiration to leverage what they'd done to create Critique. They sold Mountain View on it, and made history. Exciting times.
- jbstjohn 6mo ago
  No, Critique existed before the quick edit feature was added to Code Search. While I think the quick edits were worthwhile, it became too much too support both it and Cider (and edits in Critique), so it was removed to streamline things. As Cider became better, I think it was an okay trade-off.

by spwa4 6mo ago

There was also the code search, uh, I forgot the name "quick change", I believe? Very handy for seeing a problem, quickly solving it (sending out a CL) marking it autosubmit and just moving on.

randomCloud 6mo ago

I assume quick change became critique?

hcnews 6mo ago
There was a code reviewer starting with M before Critique iirc (Mondrian I wanna say?). The M code reviewer was completely written in Python iirc.
- spwa4 6mo ago
  No I mean that in code search you could click "edit" and just change something, which would then post a CL immediately, which you could set to auto-approve, for quick changes. I believe it was part of cider (the first non-vscode version)
  - bruckie 6mo ago
    The first version was part of Code Search proper, and wasn't super useful for much more than just typo fixes, since it was essentially just a textarea edit box. That was eventually deprecated and replaced with a button that did the same thing, but opened in Cider instead.
- rcleveng 6mo ago
  Yup, you guessed it. I was the eng manager for that for a bit, added some APIs to use to do code reviews inside of Eclipse or IntelliJ. That idea never took on, but when when I showed it to the code search team in Munich, they loved it. Critique was a fast follow.
- jbstjohn 6mo ago
  Yep, and written by Guido von Rossum, no less. However, experience with it led to my sense that Python just doesn't scale (especially back then, without type annotations) past a certain size of program. The Code Search team had been re-inventing its UI and changing a lot (changing its focus from external to internal), and had the inspiration to leverage what they'd done to create Critique. They sold Mountain View on it, and made history. Exciting times.
jbstjohn 6mo ago
No, Critique existed before the quick edit feature was added to Code Search. While I think the quick edits were worthwhile, it became too much too support both it and Cider (and edits in Critique), so it was removed to streamline things. As Cider became better, I think it was an okay trade-off.