4 ms·
What use case does a million character PR have?
by skullone 6mo ago
What use case does a million character PR have?
- justinclift 6mo agoWhen an automated system creates a PR for merging from an existing dev branch (that's been extensively tested) to "master" (or "main"). The "surprise, you can't review all the files in your PR" using GitLabs standard web based tooling makes it a no-go.
- sofixa 6mo agoThat's interesting because GitHub's web UI craps out at much less than 1 million lines. It refuses to open even low thousand line diffs.
- justinclift 6mo agoYeah, agreed it's not great for that. I'm not real happy with GitHub's worsening UX either, but it'll at least show the _names_ of all the files in the PR. With GitLab, when you hit the rate limit, any file "past" that limit doesn't even show that it exists in the MR. It just looks like the MR is missing a bunch of stuff, with no workaround available. :( :( :(
- xp84 6mo agoI’ve personally been deeply unappreciated of Github’s changes in the last few years to automatically not show diffs to “large files” without having to click to open them - which seems to be a threshold that continues to shrink. Maybe like 3 screenfuls of content is the limit now per file. It’s crazy.