3 ms·
There's two purposes to review. One is to enforce ownership, and the other is to provide mentorship. Even if you don't have ownership, mentoring is still usefu
by jjmarr 6mo ago
There's two purposes to review. One is to enforce ownership, and the other is to provide mentorship.
Even if you don't have ownership, mentoring is still useful.
I get asked for review by teammembers on an area I have expertise in.
Their solution might work but cause problems later. With review, I can knowledge transfer my lived experience so they don't suffer like I did.
The third purpose to review is stylistic nitpicking and formatting as a simulacrum of actual work. This is useless and turns people off from review.
- phyzix5761 6mo agoYes, I agree, but when the whole team is already part of the development process through mob programming there's no one who hasn't seen the code, hasn't provided feedback/mentorship, and hasn't voiced their stylistic concerns by the time the development is done.
- jjmarr 6mo agoIf your team is 5 people then sure, it's fine. From my experience in a massive shared repo with unclear ownership...