3 ms·
I like doing this as well. The 'auto merge on approval flag' PR authors can flip on GitHub breaks this flow though, as it will just merge as soon as you hit ap
by adamgordonbell 5mo ago
I like doing this as well.
The 'auto merge on approval flag' PR authors can flip on GitHub breaks this flow though, as it will just merge as soon as you hit approve.
- yojo 5mo agoI also follow this approach. I just flip the flag on the PR I’m reviewing to off before submitting my approval. We also have most of our repos set to block if unresolved comments. I think it’s a flag on branch protection rules
- namenotrequired 5mo agoThe way my company works, it doesn’t break it. You approve and merge, then any suggestions can be implemented in a next PR That way the average customer doesn’t need to wait for your code style change or edge case fix