3 ms·
Oh, phabricator. I hated that tool with a passion. It always destroyed my carefully curated PR branch history. See https://stackoverflow.com/questions/207563
by eru 7mo ago
Oh, phabricator. I hated that tool with a passion. It always destroyed my carefully curated PR branch history.
See https://stackoverflow.com/questions/20756320/how-to-prevent-phabricator-from-eating-my-commit-history https://stackoverflow.com/questions/20756320/how-to-prevent-...
- illamint 7mo agoGood. That's the point.
- eru 7mo agoThe point of what? I hope they fixed phabricator in the meantime.
- dbetteridge 7mo agoThe point is the main branch reflects the "units" of change, not the individual commits to get there. One merged pr is a unit of change, at the end of the day the steps you took to produce it aren't relevant to others. My opinion of course, I'm open to understanding why preserving individual commits is beneficial
- eru 7mo agoYou can get what you want from `git log --first-parent` without having to toss out information. See how the Linux kernel handles git history to see a good example of non-linear history and where it helps. They use merge commits, ie commits with more than one ancestor, all the time.
- saagarjha 7mo agoA unit of change is a commit. I have no idea why you'd think a PR is a unit of change.
- KwanEsq 7mo agoMy understanding was that that was more a function of how arc submitted stuff to Phabricator, rather than solely Phabricator itself. arc at submission time submitted a bunch of different commits as a single Phabricator DREV or whatever the terminology is/was (basically a DREV is the {domain}/D123 webpage you'd do a review on). But other tools that submitted commits to Phabricator instances (and maybe even arc itself with the right flag?) submitted each commit as its own separate DREV, so each commit got its own separate /D{N} page and its own review, but all linked together in a stack. And then still landed as separate commits in the actual repo. This is how code submission works with Mozilla's use of Phabricator.
- eru 7mo agoWell, I didn't care whether it was phabricator or whatever it was using. It was bad.