3 ms·

I thrive on stacked PRs but this sure seems like a weird way to implement support for it. Just have each branch point to their parent in the chain, the end. Jus

I thrive on stacked PRs but this sure seems like a weird way to implement support for it. Just have each branch point to their parent in the chain, the end. Just native Git. I've been longing for better GitHub support for this but the CLI is not where I need that support: just the UI.

sroussey 6mo ago
Yes! Maybe that feature will come next.
sameenkarim 6mo ago
The CLI is completely optional, you can create stacked PRs purely via the UI. Also the rationale for having a chain of branches pointing to each other was so the diff in a PR shows just the relevant changes from the specific branch, not the entire set of changes going back to the parent/trunk. Curious how you're thinking about it?
- herpdyderp 6mo ago
  > so the diff in a PR shows just the relevant changes from the specific branch That's exactly right. > you can create stacked PRs purely via the UI How? I see from the docs https://github.github.com/gh-stack/introduction/overview https://github.github.com/gh-stack/introduction/overview: > When a pull request is part of a stack How does GitHub determine if a PR is part of a stack? Is it automatically detected so that I don't need to adjust my tooling that already creates chained PRs?
  - sameenkarim 6mo ago
    When you're using the UI to open a PR, if you set the base to a branch that has an open PR there'll be an "Add to Stack" option: https://github.github.com/gh-stack/guides/ui/#step-2-create-subsequent-prs-and-add-them-to-the-stack https://github.github.com/gh-stack/guides/ui/#step-2-create-... Stacks require users to explicitly indicate that they are opening a PR that should be part of a stack.
    - herpdyderp 6mo ago
      It's very confusing that the "quick start" guide says the CLI is a requirement, when it's apparently not. This UI flow is exactly what I want! Thank you!
pastel8739 6mo ago
Rebasing after merging a base branch becomes a pain though, when you do this. IMO the CLI will be nice to automate the process of rebasing each branch on its parent.
- herpdyderp 6mo ago
  Agreed. I do have tooling for a rebase + push flow, but it simply calls native git commands.
godzillafarts 6mo ago
+1 this isn’t something new, it’s been possible all along in native git if you’re willing to do branch management and rebasing yourself. Just without the fancy UI / stack map.

sroussey 6mo ago

Yes! Maybe that feature will come next.

sameenkarim 6mo ago

The CLI is completely optional, you can create stacked PRs purely via the UI. Also the rationale for having a chain of branches pointing to each other was so the diff in a PR shows just the relevant changes from the specific branch, not the entire set of changes going back to the parent/trunk. Curious how you're thinking about it?

herpdyderp 6mo ago
> so the diff in a PR shows just the relevant changes from the specific branch That's exactly right. > you can create stacked PRs purely via the UI How? I see from the docs https://github.github.com/gh-stack/introduction/overview https://github.github.com/gh-stack/introduction/overview: > When a pull request is part of a stack How does GitHub determine if a PR is part of a stack? Is it automatically detected so that I don't need to adjust my tooling that already creates chained PRs?
- sameenkarim 6mo ago
  When you're using the UI to open a PR, if you set the base to a branch that has an open PR there'll be an "Add to Stack" option: https://github.github.com/gh-stack/guides/ui/#step-2-create-subsequent-prs-and-add-them-to-the-stack https://github.github.com/gh-stack/guides/ui/#step-2-create-... Stacks require users to explicitly indicate that they are opening a PR that should be part of a stack.
  - herpdyderp 6mo ago
    It's very confusing that the "quick start" guide says the CLI is a requirement, when it's apparently not. This UI flow is exactly what I want! Thank you!

pastel8739 6mo ago

Rebasing after merging a base branch becomes a pain though, when you do this. IMO the CLI will be nice to automate the process of rebasing each branch on its parent.

herpdyderp 6mo ago
Agreed. I do have tooling for a rebase + push flow, but it simply calls native git commands.

godzillafarts 6mo ago

+1 this isn’t something new, it’s been possible all along in native git if you’re willing to do branch management and rebasing yourself. Just without the fancy UI / stack map.