3 ms·

> stacked diff workflow pioneered by Phabricator Ahem, pioneered by gerrit. But actually, I'm almost certain even that wasn't original art. I think gerrit just

by js2 6mo ago

> stacked diff workflow pioneered by Phabricator Ahem, pioneered by gerrit. But actually, I'm almost certain even that wasn't original art. I think gerrit just brought it to git. https://www.gerritcodereview.com/about.html https://www.gerritcodereview.com/about.html

sunshowers 6mo ago
To my knowledge, stacked diffs were first done in the Linux kernel as stacks of patches sent over email. From there they spread to Google and Facebook. (Source: I worked on Facebook's source control team from 2012-2018 and did a lot of work to enable stacked diffs there.)
- js2 6mo ago
  Right, I was thinking from a web-based UI. The "pull request" term is from git (AFAIK), but git itself was built to accommodate the earlier concept of mailing patches around. (Source: I've been using version control since RCS/SCCS days and contributed here and there to git in its infancy. Also an early user/contributor to Gerrit.)
  - Izkata 6mo ago
    > The "pull request" term is from git (AFAIK) Possibly from github. It got popularized there at least, encouraging forking code, and is why so many people say "pull request" when they mean "merge request".
    - js2 6mo ago
      GitHub took the "pull request" terminology from Git. A kernel developer (say) would have a bunch of changes ready in their local Git server and would request a pull from Linus, hence a pull request. There's literally a command for it: https://git-scm.com/docs/git-request-pull https://git-scm.com/docs/git-request-pull The command is so old it's still written in shell: https://github.com/git/git/blob/master/git-request-pull.sh https://github.com/git/git/blob/master/git-request-pull.sh It was first added July 27, 2005: https://github.com/git/git/commit/ab421d2c7886341c246544bc8dea43c66a44d909 https://github.com/git/git/commit/ab421d2c7886341c246544bc8d... https://lore.kernel.org/git/20050726073036.GJ6098@mythryan2.michonline.com/ https://lore.kernel.org/git/20050726073036.GJ6098@mythryan2.... But even then, it simply codified existing terminology. Ah, someone else did the research, so minimally BitKeeper had the "pull" command first and the term "pull request" falls naturally from that: https://rdnlsmith.com/posts/2023/004/pull-request-origins/ https://rdnlsmith.com/posts/2023/004/pull-request-origins/
- p-e-w 6mo ago
  At some point, a derivative idea becomes so different from the original one that it’s a novel idea in essence. Just like SMS is ultimately a derivative of cuneiform tablets, and yet it isn’t in any meaningful sense.
  - monster_truck 6mo ago
    Imagine gettting a cuneiform tablet by courier telling you that you have unpaid parking tickets in a state you've never driven in
  - sunshowers 6mo ago
    I don't think mailing stacks of patches is that different? As someone who built this stuff it was pretty obvious to me that web-based patch stack management was a relatively small evolution over mailing lists. Tools like patchwork bridged the gap initially, and we were quite familiar with them.
- hokumguru 6mo ago
  Congrats and thank you. You helped build one of the best devex experiences I've ever had the pleasure of working with :)
pabs3 6mo ago
Gerrit was forked from Rietveld. Not sure if Rietveld or Gerrit are better though. https://github.com/rietveld-codereview/rietveld https://github.com/rietveld-codereview/rietveld https://en.wikipedia.org/wiki/Rietveld_(software) https://en.wikipedia.org/wiki/Rietveld_(software) https://codereview.appspot.com/ https://codereview.appspot.com/
- deleted 6mo ago
  [deleted]

by js2 6mo ago

sunshowers 6mo ago

To my knowledge, stacked diffs were first done in the Linux kernel as stacks of patches sent over email. From there they spread to Google and Facebook. (Source: I worked on Facebook's source control team from 2012-2018 and did a lot of work to enable stacked diffs there.)

js2 6mo ago
Right, I was thinking from a web-based UI. The "pull request" term is from git (AFAIK), but git itself was built to accommodate the earlier concept of mailing patches around. (Source: I've been using version control since RCS/SCCS days and contributed here and there to git in its infancy. Also an early user/contributor to Gerrit.)
- Izkata 6mo ago
  > The "pull request" term is from git (AFAIK) Possibly from github. It got popularized there at least, encouraging forking code, and is why so many people say "pull request" when they mean "merge request".
  - js2 6mo ago
    GitHub took the "pull request" terminology from Git. A kernel developer (say) would have a bunch of changes ready in their local Git server and would request a pull from Linus, hence a pull request. There's literally a command for it: https://git-scm.com/docs/git-request-pull https://git-scm.com/docs/git-request-pull The command is so old it's still written in shell: https://github.com/git/git/blob/master/git-request-pull.sh https://github.com/git/git/blob/master/git-request-pull.sh It was first added July 27, 2005: https://github.com/git/git/commit/ab421d2c7886341c246544bc8dea43c66a44d909 https://github.com/git/git/commit/ab421d2c7886341c246544bc8d... https://lore.kernel.org/git/20050726073036.GJ6098@mythryan2.michonline.com/ https://lore.kernel.org/git/20050726073036.GJ6098@mythryan2.... But even then, it simply codified existing terminology. Ah, someone else did the research, so minimally BitKeeper had the "pull" command first and the term "pull request" falls naturally from that: https://rdnlsmith.com/posts/2023/004/pull-request-origins/ https://rdnlsmith.com/posts/2023/004/pull-request-origins/
p-e-w 6mo ago
At some point, a derivative idea becomes so different from the original one that it’s a novel idea in essence. Just like SMS is ultimately a derivative of cuneiform tablets, and yet it isn’t in any meaningful sense.
- monster_truck 6mo ago
  Imagine gettting a cuneiform tablet by courier telling you that you have unpaid parking tickets in a state you've never driven in
- sunshowers 6mo ago
  I don't think mailing stacks of patches is that different? As someone who built this stuff it was pretty obvious to me that web-based patch stack management was a relatively small evolution over mailing lists. Tools like patchwork bridged the gap initially, and we were quite familiar with them.
hokumguru 6mo ago
Congrats and thank you. You helped build one of the best devex experiences I've ever had the pleasure of working with :)

pabs3 6mo ago

Gerrit was forked from Rietveld. Not sure if Rietveld or Gerrit are better though. https://github.com/rietveld-codereview/rietveld https://github.com/rietveld-codereview/rietveld https://en.wikipedia.org/wiki/Rietveld_(software) https://en.wikipedia.org/wiki/Rietveld_(software) https://codereview.appspot.com/ https://codereview.appspot.com/

deleted 6mo ago
[deleted]