3 ms·
Commits are immutable and you never know which feedback goes stale when you add another commit. I'm not a huge fan, since stacked PRs mean the underlying issue
by stephbook 6mo ago
Commits are immutable and you never know which feedback goes stale when you add another commit.
I'm not a huge fan, since stacked PRs mean the underlying issues don't get addressed (reviews clearly taking too long, too much content in there), but it seems they want something that works for their customers, right now, as they work in real life.
- normie3000 6mo ago> Commits are immutable I guess this is why you're getting downvoted. Commits can be edited.
- steveklabnik 6mo agoWhen you edit a commit, it creates a new commit. They are immutable. You can still find the old commit via the reflog, until it gets eventually gc'd. If I had to guess a reason they were downvoted (and I didn't downvote, to be clear), it's probably because people see stacked diffs as specifically solving "reviews clearly taking too long, too much content in there", and so it feels contradictory. Then again, as I said, I didn't downvote!
- normie3000 6mo agoThank you for the correction.
- mortar 6mo agoI agree with the sentiment but hash collisions can occur with different content which doesn’t really make them immutable.