it would be better to make p a const char* though, so that the code is not casting away the constness of the string literal (which can invoke undefined behaviou

it would be better to make p a const char* though, so that the code is not casting away the constness of the string literal (which can invoke undefined behaviour, though in practice string literals are going to be in a read-only area of memory anyway).