4 ms·
That's a generalized statement. Smart pointers can stabilize things, if used wrongly they can cause just as many issues. Sprinkling in smart pointers such that
by chris_money202 7mo ago
That's a generalized statement. Smart pointers can stabilize things, if used wrongly they can cause just as many issues. Sprinkling in smart pointers such that there is now mixed use with smart and raw pointers can cause double frees, and huge maintenance issues. So, creating a single PR to introduce smart pointers in my opinion is not necessarily "stability". He should have created an architecture plan and got upstream and downstream aligned.
- andyg_blog 7mo agoCompletely agree on alignment. Without it, it's a shortcut to rejection. I actually wrote a lot about this in a blog post I called "Minimum Reviewable Unit" https://gieseanw.wordpress.com/2025/03/21/minimum-reviewable-unit/ https://gieseanw.wordpress.com/2025/03/21/minimum-reviewable...