4 ms·
Augh. Some really craptastic distro-specific code in there. The wrapper script tries to detect missing dependencies on its own (gee... aren't package dependen
by ajross 14y ago
Augh. Some really craptastic distro-specific code in there. The wrapper script tries to detect missing dependencies on its own (gee... aren't package dependencies already handled by something, maybe the package manager?) and install them via "gksudo apt-get ...". Sigh...
Valve: come on guys, get it right. Look at how Chrome or Dropbox do this for a clean example. Basically, you define your own repository and your "install now" link simply adds it (and its key) and pulls your package via apt/yum/zypper/whatever.
- kevindication 14y agoA Beta test is usually a call for this kind of feedback. You should send it to them. Save the HN comment for after the Beta.
- ajross 14y agoI'm not in the beta (just used the download link above) so sadly I lack such a channel. But broadly in my experience your suggestion simply doesn't work. Betas are for bug reports. Criticism of the code never makes it to the dev team, period. On the other hand, it strikes me as quite likely that some of them read HN...
- avolcano 14y agoThis might sound ridiculous, but Valve are actually really good at responding, or at least reading, emails sent right to the top. If you just send your thoughts to gaben@valvesoftware.com, I'm sure he'll forward it to whoever it's relevant to. (I say this from experience - I sent him an email saying I thought the end of Half Life 2: Episode 2 was really fantastic stuff, and got a response back from the script writer, who he had forwarded the email to :])
- FaceKicker 14y agoI've always been curious - is it known whether Gabe himself actually reads emails from non-employees sent to that address, or could it just be an assistant that handles routing most of the emails? I really can't imagine how he could possibly have time to deal with a public email account, but maybe I'm overestimating the volume of email he would get...
- nitrogen 14y agoOne 25-employee company I was aware of during the first .com wave had at least three different people handling mail sent to the CEO's public address.
- Tobu 14y agoIn that spirit: Dear Valve, please follow the xdg-user-dirs spec instead of sticking ~/.steam ~/.steampath ~/.steampid and ~/Steam in my home directory. This is the kind of thing that should be caught very early if you don't want to be stuck with migration scripts and corner cases.
- jvert 14y agoThose things are explicitly added post-install because a package can't have cross-architecture dependencies and not all the 10.4 packages support multiarch. For example, if your 32-bit package depends on xboxdrv, it can't install on an Ubuntu 10.4 x64 system. (ditto for libappindicator1, jockey-common, etc) I don't see how defining our own repository helps this problem at all. (and isn't what dropbox, chrome, etc. do anyway) Thanks for the feedback though.
- ajross 14y agoHah! I knew you guys were watching. First, I'm quite certain that is what dropbox and chrome do, but I'll leave research to you if you like. And yes: getting cross distro (and especially multilib) support working is a big mess. But what you're doing is just awful. The scripts as-is are completely unusable on a Fedora box, because you've mixed "maintain the package installation" with "check for updates" with "run the binary" in a way that can't be cleanly separated. I'd literally have to rewrite most of your stuff just to use it, and that's dumb. Other providers (Skype is another good example, by the way) don't have this problem. Please study their solutions.
- pja 14y agoSeconding this: Doing a post-post-install in a script installed in /usr/bin is horrible! Is targeting Ubuntu 10.4 a hard requirement? I suppose it's the last LTS release, but surely the users Valve is targetting would almost all have upgraded past 10.4 by now, and the 12.04 LTS release has already happened. Anything more recent than 11.04 has proper mutli-arch support in dpkg/apt so you can specify that your package needs both 64 and 32 bit versions of some packages. Your approach seems extremely fragile: is seamless 10.04 support such a necessity? Incidentally, your compiled binary is compiled against a more recent libc than was shipped in Ubuntu 10.4, so it will currently refuse to run on 10.4 anyway. I'm guessing you compiled in on an Ubuntu 12.04 install, since it has a hard requirement for a libc version 2.15 or above. This means it won't run on anything older than Ubuntu (12.04), nor will it run on the current or the next Debian release.
- 14y ago
- mathnode 14y agoPlease tell them this, maybe on the community hub page!
- makomk 14y agoIt's not just the Steam wrapper script that does this, at least one of the games (SpaceChem) tries to do the same thing...