3 ms·
> Code a simple bug fix 30 minutes > Get it code reviewed by the peer next to you 300 minutes → 5 hours → half a day Is it takes 5 hours for a peer to review
by riffraff 7mo ago
> Code a simple bug fix
30 minutes
> Get it code reviewed by the peer next to you
300 minutes → 5 hours → half a day
Is it takes 5 hours for a peer to review a simple bugfix your operation is dysfunctional.
- habinero 7mo agoPeople are busy, and small bugfixes are usually not that critical. If you make everyone drop everything to review everything, that is much more dysfunctional.
- cindyllm 7mo ago[dead]
- thi2 7mo agoIts rare that devs are on standby, waiting for a pr to review. Usually they are working on their own pr, are in meetings, have focus time. We talked a lot about the costs of context switches so its reasonable to finish your work before switching to the review.
- karel-3d 7mo agonobody will immediately jump on your code review
- riffraff 7mo agoSure, but five hours is a lot of time, and a small fix takes little to review. So, 1 hour? Sure. Two hours? Ok. But five hours means you only look at your teammates code once a day. It's ok for a process where you work on something for a week and then come back for reviews but then it's silly to complain about overhead.
- ge96 7mo agoHehe I'm waiting right now, should have been reviewed yesterday but I'm like alright, I'll just chill then.