3 ms·
That's why code reviews exist, it's good process to make code reviews mandatory.
by fooker 8mo ago
That's why code reviews exist, it's good process to make code reviews mandatory.
- mrkeen 8mo agoIt's too much of a stretch to call null an escape hatch, or to pretend that code reviews will somehow strip it out. The OpenJDK HashMap returns null from get(), put() and remove(), among others. Is this just because it hasn't been reviewed enough yet?
- fooker 8mo ago> pretend that code reviews will somehow strip it out. Code reviews 'somehow' strip out poorly thought out new uses of escape hatches. For your example, it would be an use of get, put or remove without checking the result.