2 ms·
I am absolutely not the target market for this, however I have some comments from what I could look at quickly on a phone: - a good chunk of data seems to be p
by stephenr 7mo ago
I am absolutely not the target market for this, however I have some comments from what I could look at quickly on a phone:
- a good chunk of data seems to be passed around in associative arrays; It would be much easier to understand, and enforce type safety if you use Model and/or DTO classes.
- you're storing currency amounts using decimals in the database which is fine, but using floats in the app code is a problem. Floating point maths is not precise. Either use integers (and convert to a float for display purposes) or use something like the BCMath extension.
- there seems to be huge swathes of inline styles in your views. This just sounds painful to manage/style/adjust over time.
- best practice is to have a subdirectory which is specified as the docroot and includes just the public assets (images, css, etc) and the front controller (index.php)
- your php code defaults to the currency symbol for Indian rupees but the stripe gateway at least defaults to USD.