4 ms·
Until you unintentionally pull in a vulnerability or intentional backdoor. Every PR needs to be reviewed.
by protocolture 9mo ago
Until you unintentionally pull in a vulnerability or intentional backdoor. Every PR needs to be reviewed.
- throwaway150 9mo ago> Every PR needs to be reviewed. Why would you review a PR that you are never going to merge?
- allthetime 9mo agoYou have to first determine whether or not you might want to merge it...
- protocolture 9mo agoHaving not reviewed it, how do you know you are never going to merge?
- throwaway150 9mo agoIf a PR claims to solve a problem that I don't need, then I can skip its review because I'll never merge it. I don't think every PR needs reviewing. Some PRs we can ignore just by taking a quick look at what the PR claims to do. This only requires a quick glance, not a PR review.
- mwwaters 9mo agoI took this thread as asking whether PRs that are pulled in should be reviewed.
- zahlman 9mo agoThe point was that you can also just reject an PR on the basis of what it purports to implement, or even just blanket ignore all PRs. You can't pull in what you don't... pull in.