3 ms·
If all of these things are about making it build under clang though they need to better explain it or maybe group these changes together though. My initial com
by dwroberts 9mo ago
If all of these things are about making it build under clang though they need to better explain it or maybe group these changes together though.
My initial comment was maybe unfair but I can completely sympathise with the maintainers etc. that separately these PRs look like random small edits (e.g. from a linter) with no specific goal
- imcritic 9mo agoShouldn't small trivial changes be easier to review (and thus maybe even have higher prio)?
- gf000 9mo agoIf there is a single maintainer of the project, sure. If it's such a massively huge project like OpenJDK, then not really. You might also check how non-trivial it is to get a change into the Linux kernel.