3 ms·
If I was going to nitpick it I would point out that `itemsCount` could easily be confused with `items.Count`, or vice versa, depending on syntax highlighting.
by solid_fuel 9mo ago
If I was going to nitpick it I would point out that `itemsCount` could easily be confused with `items.Count`, or vice versa, depending on syntax highlighting. That kind of bug can have a negative impact if one or the other is mutated while the function is running.
So clearly distinguishing the local `numberOfItems` from `items.Count` _could_ be helpful. But I wouldn't ping it in a review.
- layer8 9mo agoThat’s why it’s `itemCount` and not `itemsCount`. ;) (Because the correct English term is “item count”, not “items count”.) Personally, I tend to only name it “count” if it’s a variable that is used to keep a count, i.e. it is continually incremented as new items are processed. Otherwise I tend to prefer `numItems`. Yes, this is very close to bike-shedding. There is, however, an argument to be made for consistency in a code base.