3 ms·
I agree, I will rework this part. The main challenge was support for IE on this one.
by vlamanna 14y ago
I agree, I will rework this part. The main challenge was support for IE on this one.
- sbarre 14y agoAlso on the phone part, it falls down if the phone number has an extension. I would work on a way to have the formatting decorators (parentheses, dashes etc) only show up if there is data past that point. So you could include " x" in the event that someone types in an extension or something like that. Properly parsing/formatting phone numbers is harder than you'd think.. How do you specify the mask for different numbering schemes (other regions/countries)? Do you pick one dynamically based on the selected country? Do you have that database of masks-to-country? What if my contact number is international or foreign (even if I pick my country as USA)? Do you let the user select a mask? That feels clunky and more work than just leaving the phone number free-form..
- Kudos 14y agoIt doesn't work with a numpad either. Seems terribly broken overall.
- danellis 14y agoIt also fails on UK phone numbers, because it assumes a London-style number.
- dylanz 14y agoThe phone field would be amazing to have polished, and I think you'd see a lot of adoption for just this field.
- a_m0d 14y agoIt also allows you to paste any text in, and it will no longer match the mask.
- vlamanna 14y agoWill fix it. https://github.com/vlamanna/BootstrapFormHelpers/issues/8 https://github.com/vlamanna/BootstrapFormHelpers/issues/8