3 ms·

That has nothing to do with the UI framework. The X11 dependency comes as part of the clipboard integration (which I'd argue should be optional or even removed)

That has nothing to do with the UI framework. The X11 dependency comes as part of the clipboard integration (which I'd argue should be optional or even removed). Still, I wouldn't call it modern if Wayland is outright not supported.

rvermeulen98 8mo ago
I think this is only a problem when building from source, right? It is indeed because of the dependency on https://github.com/golang-design/clipboard https://github.com/golang-design/clipboard. I hesitated a bit bringing in this feature. On one hand, I really like to have clipboard support, on the other hand, I don't like that it requires you to change from static to dynamic linking (and have the x11 dependency). Maybe I could write an install.sh script for installation that detects the OS and fetches the correct version/tarball from the Github release.
- Daviey 8mo ago
  That library isn't going to support Wayland any time soon, and requiring CGO isn't ideal IMO. See this bug, https://github.com/golang-design/clipboard/issues/6 https://github.com/golang-design/clipboard/issues/6 How about this PR? https://github.com/ramonvermeulen/whosthere/pull/29 https://github.com/ramonvermeulen/whosthere/pull/29 It switches to using github.com/dece2183/go-clipboard, which supports Mac, Windows, Linux (X11 + Wayland) and Android.
  - rvermeulen98 8mo ago
    Thanks a lot for your contribution, this is something I will look into in the upcoming days. I totally agree that CGO isn't ideal, I had to make the build/release process also a lot more complicated purely for that clipboard requirement (see GHAs and the different goreleaser files). On the other hand, I also don't want whosthere to be depended on a fork that isn't maintained anymore. I will think about this trade-off, but I am also interested how others look at this problem.
ok123456 8mo ago
What's modern about Wayland?

rvermeulen98 8mo ago

I think this is only a problem when building from source, right? It is indeed because of the dependency on https://github.com/golang-design/clipboard https://github.com/golang-design/clipboard. I hesitated a bit bringing in this feature. On one hand, I really like to have clipboard support, on the other hand, I don't like that it requires you to change from static to dynamic linking (and have the x11 dependency). Maybe I could write an install.sh script for installation that detects the OS and fetches the correct version/tarball from the Github release.

Daviey 8mo ago
That library isn't going to support Wayland any time soon, and requiring CGO isn't ideal IMO. See this bug, https://github.com/golang-design/clipboard/issues/6 https://github.com/golang-design/clipboard/issues/6 How about this PR? https://github.com/ramonvermeulen/whosthere/pull/29 https://github.com/ramonvermeulen/whosthere/pull/29 It switches to using github.com/dece2183/go-clipboard, which supports Mac, Windows, Linux (X11 + Wayland) and Android.
- rvermeulen98 8mo ago
  Thanks a lot for your contribution, this is something I will look into in the upcoming days. I totally agree that CGO isn't ideal, I had to make the build/release process also a lot more complicated purely for that clipboard requirement (see GHAs and the different goreleaser files). On the other hand, I also don't want whosthere to be depended on a fork that isn't maintained anymore. I will think about this trade-off, but I am also interested how others look at this problem.

ok123456 8mo ago

What's modern about Wayland?