6 ms·

> Older alternatives like sandbox-2 exist, but they provide isolation near the OS level, not the language level. At that point we might as well use Docker or VM

by petters 9mo ago

> Older alternatives like sandbox-2 exist, but they provide isolation near the OS level, not the language level. At that point we might as well use Docker or VMs. No,no, Docker is not a sandbox for untrusted code.

mavdol04 9mo ago
You're right, Docker isn't a sandbox for untrusted code. I mentioned it because I've seen teams default to using it for isolating their agents on larger servers. So I made sure to clarify in the article that it's not secure for that purpose.
- ottah 9mo ago
  It depends on the task, and the risk of isolation failure. Docker can be sufficient if inputs are from trusted sources and network egress is reasonably limited.
s_ting765 9mo ago
Docker provides some host isolation which can be used effectively as a sandbox. It's not designed for security (and it does have some reasonable defaults) but it does give you options to layer on security modules like apparmor and seccomp very easily.
ashishb 9mo ago
Show me how you will escape a docker sandbox.
- staticassertion 9mo ago
  Exploit the Linux kernel underneath it (not the only way, just the obvious one). Docker is a security boundary but it is not suitable for "I'm running arbitrary code". That is to say, Docker is typically a security win because you get things like seccomp and user/DAC isolation "for free". That's great. That's a win. Typically exploitation requires a way to get execution in the environment plus a privilege escalation. The combination of those two things may be considered sufficient. It is not sufficient for "I'm explicitly giving an attacker execution rights in this environment" because you remove the cost of "get execution in the environment" and the full burden is on the kernel, which is not very expensive to exploit.
  - ashishb 9mo ago
    > Exploit the Linux kernel underneath it (not the only way, just the obvious one). Docker is a security boundary but it is not suitable for "I'm running arbitrary code". Dockler is better for running arbitrary code compared to the direct `npm install <random-package>` that's common these days. I moved to a Dockerized sandbox[1], and I feel much better now against such malicious packages. 1 - https://github.com/ashishb/amazing-sandbox
    - staticassertion 9mo ago
      It's better than nothing, obviously. But I don't consider `npm install <random-package>` to be equivalent to "RCE as a service", although it's somewhat close. I definitely wouldn't recommend `npm install <actually a random package>`, even in Docker. I also implemented `insanitybit/cargo-sandbox` using Docker but that doesn't mean I think `insanitybit/cargo-sandbox` is a sufficient barrier to arbitrary code execution, which is why I also had a hardened `cargo add` that looked for typosquatting of package names, and why I think package manager security in general needs to be improved. You can and should feel better about running commands like that in a container, as I said - seccomp and DAC are security boundaries. I wouldn't say "you should feel good enough to run an open SSH server and publish it for anyone to use".
      - ashishb 9mo ago
        > definitely wouldn't recommend `npm install <actually a random package>`, even in Docker. That's not the main attack vector. The attack vector is some random dependency that is used by a lot of popular packages, which you `npm install` indirectly.
        staticassertion 9mo ago
        That doesn't change what I said. It definitely doesn't change what I said about docker as a security boundary. Again, it's great to run `npm` in a container. I do that too because it's the lowest effort solution I have available.
- neoCrimeLabs 9mo ago
  This is a well understood and well documented subject. Do your own research. Start here to help give you ideas for what to research: https://linuxsecurity.com/features/what-is-a-container-escape-vulnerability https://linuxsecurity.com/features/what-is-a-container-escap...
  - ashishb 9mo ago
    > This is a well understood and well documented subject. Do your own research. Anything including GNU/Linux kernel can be broken with such security vulnerabilities. This is not a weakness in the design of containers. `npm install`, on the other hand, is broken by design (due to post-install.
    - neoCrimeLabs 9mo ago
      > This is not a weakness in the design of containers. Partially correct. Many container escapes are also because the security of the underlying host, container runtime, or container itself was poorly or inconsistently implemented. This creates gaps that allow escapes from the container. There is a much larger potential for mistakes, creating a much larger attack surface. This is in addition to kernel vulnerabilities. While you can implement effective hardening across all the layers, the potential for misconfiguration is still there, therefore there is still a large attack surface. While a virtual host can be escaped from, the attack surface is much smaller, leaving less room for potential escapes. This is why containers are considered riskier for a sandbox than a virtual host. Which one you use, and why, really should depend on your use case and threat model. Sad to say it, a disappointing amount of people don't put much hardening into their container environments, including production k8s clusters. So it's much easier to say that a virtual host is better for sandboxing than containers, because many people are less likely to get it wrong.
      - ashishb 9mo ago
        > Many container escapes are also because the security of the underlying host, container runtime, or container itself was poorly or inconsistently implemented. Sure, so running `npm install` inside the container is no worse than `npm install` on my machine. And in most cases, it is much better.
neoCrimeLabs 9mo ago
It depends on your threat model, but generally speaking would not trust default container runtimes for a true sandbox. The kata-containers [1] runtime takes a container and runs it as a virtual host. It works with Docker, podman, k8s, etc. It's a way to get the convenience of a container, but benefits of a virtual host. This is not do-all-end-all, (there are more options), but this is a convenient one that is better than typical containers. [1] - https://katacontainers.io/ https://katacontainers.io/
maple3142 9mo ago
I don't think it is generally possible to escape from a docker container in default configuration (e.g. `docker run --rm -it alpine:3 sh`) if you have a reasonably update-to-date kernel from your distro. AFAIK a lot of kernel lpe use features like unprivileged user ns and io_uring which is not available in container by default, and truly unprivileged kernel lpe seems to be sufficient rare.
- staticassertion 9mo ago
  The kernel policy is that any distro that isn't using a rolling release kernel is unpatched and vulnerable, so "reasonably up-to-date" is going to lean heavily on what you consider "reasonable". LPEs abound - unprivileged user ns was a whole gateway that was closed, io-uring was hot for a while, ebpf is another great target, and I'm sure more and more will be found every year as has been the case. Seccomp and unprivileged containers etc make a huge different to stomp out a lot of the attack surface, you can decide how comfortable you are with that though.
  - gruez 9mo ago
    >The kernel policy is that any distro that isn't using a rolling release kernel is unpatched and vulnerable, so "reasonably up-to-date" is going to lean heavily on what you consider "reasonable". I would expect major distributions to have embargoed CVE access specifically to prevent this issue.
    - staticassertion 9mo ago
      Nope, that is not the case. For one thing, upstream doesn't issue CVEs and doesn't really care about CVEs or consider them valid. For another, they forbid or severely limit embargos.
senko 9mo ago
What if I told you that, back in the day, we were letting thousands of untrusted, unruly, mischievous people execute arbitrary code on the same machine, and somehow, the world didn't end? We live in a bizarre world where somehow "you need a hypervisor to be secure" and "to install this random piece of software, run curl | sudo bash" can live next to each other and both be treated seriously.
- akimbostrawman 9mo ago
  9/10 times i see curl | sudo bash mentioned, its about it being bad so I don't think that's a good comparison.

by petters 9mo ago

mavdol04 9mo ago

You're right, Docker isn't a sandbox for untrusted code. I mentioned it because I've seen teams default to using it for isolating their agents on larger servers. So I made sure to clarify in the article that it's not secure for that purpose.

ottah 9mo ago
It depends on the task, and the risk of isolation failure. Docker can be sufficient if inputs are from trusted sources and network egress is reasonably limited.

s_ting765 9mo ago

Docker provides some host isolation which can be used effectively as a sandbox. It's not designed for security (and it does have some reasonable defaults) but it does give you options to layer on security modules like apparmor and seccomp very easily.

ashishb 9mo ago

Show me how you will escape a docker sandbox.

staticassertion 9mo ago
Exploit the Linux kernel underneath it (not the only way, just the obvious one). Docker is a security boundary but it is not suitable for "I'm running arbitrary code". That is to say, Docker is typically a security win because you get things like seccomp and user/DAC isolation "for free". That's great. That's a win. Typically exploitation requires a way to get execution in the environment plus a privilege escalation. The combination of those two things may be considered sufficient. It is not sufficient for "I'm explicitly giving an attacker execution rights in this environment" because you remove the cost of "get execution in the environment" and the full burden is on the kernel, which is not very expensive to exploit.
- ashishb 9mo ago
  > Exploit the Linux kernel underneath it (not the only way, just the obvious one). Docker is a security boundary but it is not suitable for "I'm running arbitrary code". Dockler is better for running arbitrary code compared to the direct `npm install <random-package>` that's common these days. I moved to a Dockerized sandbox[1], and I feel much better now against such malicious packages. 1 - https://github.com/ashishb/amazing-sandbox
  - staticassertion 9mo ago
    It's better than nothing, obviously. But I don't consider `npm install <random-package>` to be equivalent to "RCE as a service", although it's somewhat close. I definitely wouldn't recommend `npm install <actually a random package>`, even in Docker. I also implemented `insanitybit/cargo-sandbox` using Docker but that doesn't mean I think `insanitybit/cargo-sandbox` is a sufficient barrier to arbitrary code execution, which is why I also had a hardened `cargo add` that looked for typosquatting of package names, and why I think package manager security in general needs to be improved. You can and should feel better about running commands like that in a container, as I said - seccomp and DAC are security boundaries. I wouldn't say "you should feel good enough to run an open SSH server and publish it for anyone to use".
    - ashishb 9mo ago
      > definitely wouldn't recommend `npm install <actually a random package>`, even in Docker. That's not the main attack vector. The attack vector is some random dependency that is used by a lot of popular packages, which you `npm install` indirectly.
      - staticassertion 9mo ago
        That doesn't change what I said. It definitely doesn't change what I said about docker as a security boundary. Again, it's great to run `npm` in a container. I do that too because it's the lowest effort solution I have available.
neoCrimeLabs 9mo ago
This is a well understood and well documented subject. Do your own research. Start here to help give you ideas for what to research: https://linuxsecurity.com/features/what-is-a-container-escape-vulnerability https://linuxsecurity.com/features/what-is-a-container-escap...
- ashishb 9mo ago
  > This is a well understood and well documented subject. Do your own research. Anything including GNU/Linux kernel can be broken with such security vulnerabilities. This is not a weakness in the design of containers. `npm install`, on the other hand, is broken by design (due to post-install.
  - neoCrimeLabs 9mo ago
    > This is not a weakness in the design of containers. Partially correct. Many container escapes are also because the security of the underlying host, container runtime, or container itself was poorly or inconsistently implemented. This creates gaps that allow escapes from the container. There is a much larger potential for mistakes, creating a much larger attack surface. This is in addition to kernel vulnerabilities. While you can implement effective hardening across all the layers, the potential for misconfiguration is still there, therefore there is still a large attack surface. While a virtual host can be escaped from, the attack surface is much smaller, leaving less room for potential escapes. This is why containers are considered riskier for a sandbox than a virtual host. Which one you use, and why, really should depend on your use case and threat model. Sad to say it, a disappointing amount of people don't put much hardening into their container environments, including production k8s clusters. So it's much easier to say that a virtual host is better for sandboxing than containers, because many people are less likely to get it wrong.
    - ashishb 9mo ago
      > Many container escapes are also because the security of the underlying host, container runtime, or container itself was poorly or inconsistently implemented. Sure, so running `npm install` inside the container is no worse than `npm install` on my machine. And in most cases, it is much better.

neoCrimeLabs 9mo ago

It depends on your threat model, but generally speaking would not trust default container runtimes for a true sandbox. The kata-containers [1] runtime takes a container and runs it as a virtual host. It works with Docker, podman, k8s, etc. It's a way to get the convenience of a container, but benefits of a virtual host. This is not do-all-end-all, (there are more options), but this is a convenient one that is better than typical containers. [1] - https://katacontainers.io/ https://katacontainers.io/

maple3142 9mo ago

I don't think it is generally possible to escape from a docker container in default configuration (e.g. `docker run --rm -it alpine:3 sh`) if you have a reasonably update-to-date kernel from your distro. AFAIK a lot of kernel lpe use features like unprivileged user ns and io_uring which is not available in container by default, and truly unprivileged kernel lpe seems to be sufficient rare.

staticassertion 9mo ago
The kernel policy is that any distro that isn't using a rolling release kernel is unpatched and vulnerable, so "reasonably up-to-date" is going to lean heavily on what you consider "reasonable". LPEs abound - unprivileged user ns was a whole gateway that was closed, io-uring was hot for a while, ebpf is another great target, and I'm sure more and more will be found every year as has been the case. Seccomp and unprivileged containers etc make a huge different to stomp out a lot of the attack surface, you can decide how comfortable you are with that though.
- gruez 9mo ago
  >The kernel policy is that any distro that isn't using a rolling release kernel is unpatched and vulnerable, so "reasonably up-to-date" is going to lean heavily on what you consider "reasonable". I would expect major distributions to have embargoed CVE access specifically to prevent this issue.
  - staticassertion 9mo ago
    Nope, that is not the case. For one thing, upstream doesn't issue CVEs and doesn't really care about CVEs or consider them valid. For another, they forbid or severely limit embargos.

senko 9mo ago

What if I told you that, back in the day, we were letting thousands of untrusted, unruly, mischievous people execute arbitrary code on the same machine, and somehow, the world didn't end? We live in a bizarre world where somehow "you need a hypervisor to be secure" and "to install this random piece of software, run curl | sudo bash" can live next to each other and both be treated seriously.

akimbostrawman 9mo ago
9/10 times i see curl | sudo bash mentioned, its about it being bad so I don't think that's a good comparison.