3 ms·
What am I missing that makes this change a massive headache if just setting a flag gets the old behavior?
by lovich 10mo ago
What am I missing that makes this change a massive headache if just setting a flag gets the old behavior?
- pron 10mo agoNothing makes it a massive headache, but I think that Maven/Gradle don't make it as easy as they could and should.
- okillbite 10mo agoI haven't read the discussion but this seems like the obvious answer considering the flag only needs to be set during test. Presumably this might miss some edge case (where something else also needs the flag?) though an explicit allow of the mockito agent in the jvm arg would have solved for that.
- pron 10mo ago> though an explicit allow of the mockito agent in the jvm arg would have solved for that. You can and should explicitly specify Mockito as an agent in the JVM configuration, as it is one.
- dathanb82 10mo agoThe auto-attach flag isn’t a huge deal, since it’s a one-liner that can be statically documented and the fix works in all cases. The bigger issue is the JDK / runtime team’s stance that libraries should not be able to dynamically attach agents, and that the auto-attach flag might be removed in the future. You can still enable mockito’s agent with the —javaagent flag, but you have to provide the path to the mockito jar, and getting that path right is highly build-system-dependent and not something the mockito team can document in a way that minimizes the entry threshold for newcomers.
- deleted 10mo ago[deleted]