4 ms·

Code reviews are not only about raising quality, but mainly about communicating changes to the wider team. Suggesting to eliminate code reviews when LLM use is

by manmal 10mo ago

Code reviews are not only about raising quality, but mainly about communicating changes to the wider team. Suggesting to eliminate code reviews when LLM use is so rampant is also quite uhm courageous.

cloogshicer 10mo ago
The author never suggested to eliminate code reviews entirely. Just to give individuals more autonomy, which is great in my book.
- heyitsdaad 10mo ago
  Hard no buddy. Junior dev means junior code and junior judgement. Countless times we had prod issues because some dev thought the change was harmless and they didn't need review.
  - cloogshicer 10mo ago
    In the article, they specifically exclude juniors and people who are still being onboarded.
    - jinushaun 10mo ago
      I can’t find that disclaimer in the article.
      - AntonZ234 10mo ago
        OP here. In this one the closest is probably: "I love the process at Pylon: engineers merge their own code and only request reviews if they need input, think they have a risky change, or are still onboarding. " But I fully agree that for juniors it makes sense to have it mandatory.
- manmal 10mo ago
  PRs don’t really hurt autonomy if stacked branches are used routinely. Those do hurt speed, yes, but not autonomy. PRs are so important that I‘d never skip them within a team.
  - cloogshicer 10mo ago
    If you have a policy in place that forces engineers to wait for review before merging each PR, then yes, by definition they have less autonomy. It might still be worth the trade off in your situation, but I like the suggestion in the article where senior devs can decide themselves whether they want their code reviewed or not.
nick4 10mo ago
Communicating changes and communicating learning too! Every few years I rewatch one of my favorite videos on code reviews: https://www.youtube.com/watch?v=PJjmw9TRB7s https://www.youtube.com/watch?v=PJjmw9TRB7s. Asking questions on code reviews is one of the most powerful tools to learn more about a codebase, and fostering a culture where junior devs feel empowered to ask questions is one of the best ways to help junior devs succeed.

by manmal 10mo ago

cloogshicer 10mo ago

The author never suggested to eliminate code reviews entirely. Just to give individuals more autonomy, which is great in my book.

heyitsdaad 10mo ago
Hard no buddy. Junior dev means junior code and junior judgement. Countless times we had prod issues because some dev thought the change was harmless and they didn't need review.
- cloogshicer 10mo ago
  In the article, they specifically exclude juniors and people who are still being onboarded.
  - jinushaun 10mo ago
    I can’t find that disclaimer in the article.
    - AntonZ234 10mo ago
      OP here. In this one the closest is probably: "I love the process at Pylon: engineers merge their own code and only request reviews if they need input, think they have a risky change, or are still onboarding. " But I fully agree that for juniors it makes sense to have it mandatory.
manmal 10mo ago
PRs don’t really hurt autonomy if stacked branches are used routinely. Those do hurt speed, yes, but not autonomy. PRs are so important that I‘d never skip them within a team.
- cloogshicer 10mo ago
  If you have a policy in place that forces engineers to wait for review before merging each PR, then yes, by definition they have less autonomy. It might still be worth the trade off in your situation, but I like the suggestion in the article where senior devs can decide themselves whether they want their code reviewed or not.

nick4 10mo ago

Communicating changes and communicating learning too! Every few years I rewatch one of my favorite videos on code reviews: https://www.youtube.com/watch?v=PJjmw9TRB7s https://www.youtube.com/watch?v=PJjmw9TRB7s. Asking questions on code reviews is one of the most powerful tools to learn more about a codebase, and fostering a culture where junior devs feel empowered to ask questions is one of the best ways to help junior devs succeed.