4 ms·
This is not what secret.Enabled() means. But it probably illustrates that the function needs to be renamed already. Here's what the doc comment says: // Enab
by kbolino 10mo ago
This is not what secret.Enabled() means. But it probably illustrates that the function needs to be renamed already. Here's what the doc comment says:
// Enabled reports whether Do appears anywhere on the call stack.
In other words, it is just a way of checking that you are indeed running inside the context of some secret.Do call; it doesn't guarantee that secret.Do is actually offering the protection you may desire.
- draw_down 10mo ago[dead]
- cafxx 10mo agoThat's not how it's implemented (it returns false if you're inside a Do() on a unsupported platform), although I agree the wording should be clearer.
- cafxx 10mo agoFiled a CL for this, hopefully it gets merged ~soon. https://go-review.googlesource.com/c/go/+/729920 https://go-review.googlesource.com/c/go/+/729920