4 ms·
I think they are misreading the situation. The devil is in the details. It seems `getHeaders` v. `headers` is non-security, non-performance related issue. Why
by hartator 10mo ago
I think they are misreading the situation.
The devil is in the details. It seems `getHeaders` v. `headers` is non-security, non-performance related issue. Why people should spend time fixing these?
- CaliforniaKarl 10mo agoIf you (either directly or from SerpApi) are supporting the urllib3 folks (through a Tidelift subscription), then yes, that is a valid point. Otherwise, I'd say that's a very brave comment you are making.
- ipaddr 10mo agoIf he gave money valid point if not he must be brave?
- shadowgovt 10mo ago"Brave" in what sense? It's a legitimate question why an API is having a pattern deprecated and removed for what appears to be pattern reasons.
- attractivechaos 10mo agoEven if getHeaders() has security/performance concerns, the better solution is to make it an alias to the newer headers.get() in this case. Keeping the old API is a small hassle to a handful of developers but breaking existing code puts a much bigger burden on a lot more users.
- nodesocket 10mo agoYa, why not just alias old api calls to the new if implementation details changed?