4 ms·

Central to it being that you consider it unjust. The other option is to take into consideration the perspective of the maintainers, find their feedback to be ju

by emerongi 10mo ago

Central to it being that you consider it unjust. The other option is to take into consideration the perspective of the maintainers, find their feedback to be just and then decide whether you want to contribute in the manner that they expect or you're not ready to do that kind of work. You don't have to stop loving a project just because you're not ready to put in the work that the maintainers expect you to put in. When I open a PR without discussing it at all beforehand with anyone, I expect the default to be that it gets rejected. It's fine by me, because it's simply easier for me to open a PR and have it be rejected than to find the people I need to talk to and then get them all onboard. I accounted for that risk when I chose the path I took.

aleph_minus_one 10mo ago
> Central to it being that you consider it unjust. I assume this is a correct characterization of how joelreymont feels about the fact that his PR was rejected.
- joelreymont 10mo ago
  It's not. It's absolutely justified for the OCaml maintainers to reject this PR. I feel completely different about my Zig PR [1] but, hey, it's not my playground and the Zig folks seem to be particularly opinionated. [1] https://ziggit.dev/t/bug-wrong-segment-ordering-for-macos-using-the-non-llvm-arm64-backend/13221 https://ziggit.dev/t/bug-wrong-segment-ordering-for-macos-us...
  - noitpmeder 10mo ago
    It is truly unfortunate for you that your actions have probably tainted your future open source contributions for a long time.
  - jkman 10mo ago
    Do you have no shame, man?
thwarted 10mo ago
> When I open a PR without discussing it at all beforehand with anyone, I expect the default to be that it gets rejected. TNG S2E8, "A Matter Of Honor" is about this topic. The submitter introduced risk on the maintainers (the risk being here largely eating up the maintainers time needlessly) by working in isolation and only presenting the finished work without any feedback or awareness from the rest of the participants.

aleph_minus_one 10mo ago

> Central to it being that you consider it unjust. I assume this is a correct characterization of how joelreymont feels about the fact that his PR was rejected.

joelreymont 10mo ago
It's not. It's absolutely justified for the OCaml maintainers to reject this PR. I feel completely different about my Zig PR [1] but, hey, it's not my playground and the Zig folks seem to be particularly opinionated. [1] https://ziggit.dev/t/bug-wrong-segment-ordering-for-macos-using-the-non-llvm-arm64-backend/13221 https://ziggit.dev/t/bug-wrong-segment-ordering-for-macos-us...
- noitpmeder 10mo ago
  It is truly unfortunate for you that your actions have probably tainted your future open source contributions for a long time.
- jkman 10mo ago
  Do you have no shame, man?

thwarted 10mo ago

> When I open a PR without discussing it at all beforehand with anyone, I expect the default to be that it gets rejected. TNG S2E8, "A Matter Of Honor" is about this topic. The submitter introduced risk on the maintainers (the risk being here largely eating up the maintainers time needlessly) by working in isolation and only presenting the finished work without any feedback or awareness from the rest of the participants.