5 ms·

Select 1 Touches 5,583 Lines of Postgres Source Code

• sam_lowry_ 11mo ago
  Heh... For a long time I wanted to fix the message Postgres shows when connecting to the Database with the higher version of the CLI as it gives a somewhat misleading perception of lack of backwards compatibility. Every time I accidentally stumble into that message, I check on the Postgres code, see how hard it is to fix the message and bail out.
  • anarazel 11mo ago
    That should be trivial to change: https://github.com/postgres/postgres/blob/d2f24df19b7a42a0944a6926a0ca54168dcefe3a/src/bin/psql/command.c#L4471-L4483 https://github.com/postgres/postgres/blob/d2f24df19b7a42a094...
    • sam_lowry_ 11mo ago
      Think of all the translations )
      • anarazel 11mo ago
        You don't need to deal with them as a patch author :)
    • ngalstyan4 11mo ago
      They would need to handle all the translation changes as well, no? <https://github.com/search?q=repo%3Apostgres%2Fpostgres+%22major+version+%25s%2C+server+major+version%22&type=code https://github.com/search?q=repo%3Apostgres%2Fpostgres+%22ma...> I agree code change is simple, but I guess the task is complex for other reasons
      • anarazel 11mo ago
        If you just make a change of code, you don't need to handle translations at that time. That will get done by the various translation teams closer to the release. However you do need to make sure that the code is translatable (e.g. injecting pre-formulated english messages into a larger message is problematic).