4 ms·
Are you kidding me? You should be able to explain from the user PoV what does the PR achieve, a new feature? a bugfix? That data point is waaaaaay more importa
by siwatanejo 11mo ago
Are you kidding me? You should be able to explain from the user PoV what does the PR achieve, a new feature? a bugfix?
That data point is waaaaaay more important than any other when considering if you should think about reviewing it or not.
- wiseowise 11mo agoOkay, it does align. What next?
- siwatanejo 11mo agoOk great. Now that it aligns, how valuable it is? Is it a deadly & terrific feature? Then maybe you should review it. It's just fixing a nitpick? Then ask the contributor to find a less verbose change.