3 ms·
In our company, you would immediately reject the PR based on size. There are a bunch of other quick bounce items it could also fail on, eg documentation. The P
by rhubarbtree 1y ago
In our company, you would immediately reject the PR based on size. There are a bunch of other quick bounce items it could also fail on, eg documentation.
The PR would then be split into small ones up to 400 lines long.
In truth, such a big PR is an indicator that either (a) the original code is a complete mess and needs reengineering or more likely (b) the PR is vibe coded and is making lots of very poor engineering decisions and goes in the bin.
We don’t use AI agents for coding. They’re not ready. Autocomplete is fine. Agents don’t reason like engineers, they make crap PRs.
- ethin 1y agoThis! And vibe-coded solutions usually will implement stuff your project already has in it, instead of reusing what already exists. Or Claude will massively over-engineer something that could be collapsed to 30 lines or something.
- Cthulhu_ 1y agoCan confirm, I asked it to write a unit test for a small component, it wrote tons of code that parsed and validated some JSON configuration (a theme file) instead of just the unit under test. I just wrote it myself instead of try and argue with it. Maybe the AI was too clever for its own good? Have AI coding assistants evolved from junior (naive but alright) to medior (overly complicated and complete)?