4 ms·
Forget about code for a second. This all depends a lot of what goal does the PR achieve? Does it align with the goals of the project?
by siwatanejo 1y ago
Forget about code for a second. This all depends a lot of what goal does the PR achieve? Does it align with the goals of the project?
- appreciatorBus 1y agoHow can you tell if it aligns with the goals of the project without reviewing 9000 lines of code first?
- ivanjermakov 11mo agoPRs rarely exist in a vacuum. Usually there is a ticket/issue/context which required a code change.
- siwatanejo 11mo agoAre you kidding me? You should be able to explain from the user PoV what does the PR achieve, a new feature? a bugfix? That data point is waaaaaay more important than any other when considering if you should think about reviewing it or not.
- wiseowise 11mo agoOkay, it does align. What next?
- siwatanejo 11mo agoOk great. Now that it aligns, how valuable it is? Is it a deadly & terrific feature? Then maybe you should review it. It's just fixing a nitpick? Then ask the contributor to find a less verbose change.
- Cthulhu_ 11mo agoRead the title and description of the PR first. If that fails the sniff test, the code would as well.