4 ms·
It’s really important to understand what’s happening here Then maybe you should take a moment to pick more descriptive identifiers than future1, future2, futur
by octoberfranklin 1y ago
It’s really important to understand what’s happening here
Then maybe you should take a moment to pick more descriptive identifiers than future1, future2, future3, do_stuff, and do_async_thing. This coding style is atrocious.
- dap 1y agoIs it possible that those names are intentionally chosen and actually do carry meaning?
- gpm 1y agoIf you prefer "real" names you can always look at the actual code that had a bug - here it is before the bug was fixed: https://github.com/oxidecomputer/omicron/blob/a253f541a4a32a4326d7ddfc04df27c0e47de42b/nexus/src/app/background/tasks/support_bundle_collector.rs#L496-L551 https://github.com/oxidecomputer/omicron/blob/a253f541a4a32a...