3 ms·
It definitely takes me more time to review PRs now, and I have more PRs to review. Agent created code seems “fine” but also seems like 30% more than is needed (
by derwiki 1y ago
It definitely takes me more time to review PRs now, and I have more PRs to review. Agent created code seems “fine” but also seems like 30% more than is needed (total SWAG)
- Gigachad 1y agoThe worst part is how it destroys your implicit trust that the author ran and understood the code. The generated code looks fine but doesn't actually work because it was never run. So to properly review PRs today you have to spend a lot longer assuming nothing works and every detail needs to be carefully tested.
- derwiki 1y agoIs there’s no screenshots of it working or logs from a console showing it working, I kinda presume it won’t. In a previous role that was more front end facing (tablet experience for self driving cars), I had a few coworkers who would put out PRs that I knew could not have worked and were not tested. My nudge was “oh can you add a screenshot to the PR?” And they would realize it didn’t work and get back to me in a few days. Been dealing with this since before gen AI produced code haha.