3 ms·
Personal experience: > It worked exceptionally well. Most errors were caught at this phase, or inmediately before, when we were reading our own code just befor
by narag 14y ago
Personal experience:
> It worked exceptionally well. Most errors were caught at this phase, or inmediately before, when we were reading our own code just before printing it.
> We had a friendly environment.
> We had a clear pre-established set of rules. We just discussed what category an error fell into.
> Yes! it was also a way to learn to think about code and avoid similar errors next time, but some errors ocurred again anyway.
> I miss code reviews!
- joshwa 14y agoWhat was that set of rules?
- narag 14y agoThere was a document, not too long, about ten, maybe twenty pages, that covered a lot, from code formatting to cohesion, complexity, interface size... it was a very condensed summary of Code Complete with some extra material from other books. Errors were categorized as major (show-stoppers), minor (annoyances), graphical (user visible typos), design (i.e. bad layered code, fat interfaces) and style (formatting, lack or excess of comments), IIRC. There was also an authority (the boss) that was flexible enough, but had the ultimate power of solving disagreements, so we didn't get caught in endless discussions.
- danielweber 14y agoYeah, I loved them. Everyone on the team has some little thing they know that no one else does, and everyone on the team has some little gap in their knowledge. You can spread the former and diminish the latter. We didn't have any kind of rules for the reviews, but it ended up working great. That was a really nice team.