4 ms·
Given that the issue already gives a before-and-after metric it's extremely odd there's no POC PR attached. This just seems like an AI slop GitHub issue from b
by muglug 1y ago
Given that the issue already gives a before-and-after metric it's extremely odd there's no POC PR attached.
This just seems like an AI slop GitHub issue from beginning to end.
And I'd be very surprised if VS Code performance could be boosted that much by a supposedly trivial fix.
- duskwuff 1y agoEven if it is a real performance issue, the reasonable fix would be to move the sort call out of the loop - implementing a new data structure in JS is absolutely not the way to fix this.
- muglug 1y agoRight, and also this would show up in the profiler if it were a time sink — and I'm 100% certain this code has been profiled in the 10 years it's been in the codebase.
- oe 1y agoAdding a new data structure just for this feels like such an AI thing. I've added to our agents.md a rule to prefer using existing libraries and types, otherwise Gemini will just happily generate things like this.
- nneonneo 1y agoThere’s clearly functionality to push more work to the current window’s queue, so I would not be surprised if the data structure needs to be continually kept sorted. (Somewhere in the pile of VSCode dependencies you’d think there’d be a generic heap data structure though)
- gigatexal 1y agoI’ve already moved from VSCode to Zed. It’s native. Faster. Has most of the functionality I had before. I’m a huge fan.
- sillythrowawy9 1y agoOP’s account also seems automated. This certainly feel like automated post to social media for PR clout
- anticensor 1y agoNot really, I read HN more than I post to it, but I found this one interesting.
- ollin 1y agoYeah the issue reads as if someone asked Claude Code "find the most serious performance issue in the VSCode rendering loop" and then copied the response directly into GitHub (without profiling or testing anything).
- a-dub 1y agoi see emojis in the comments. also no discussion of measured runtimes for the rendering code. (if it saves ~1.3ms that sounds cool, but how many ms is that from going over the supposed 16ms budget.)